Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lvBxh-0006Ua-Sa for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Jun 2021 04:55:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lvBxf-00085F-77 for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Jun 2021 04:55:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lvBxe-000857-Vr for pgsql-hackers@lists.postgresql.org; Mon, 21 Jun 2021 04:55:02 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lvBxa-00066u-Mi for pgsql-hackers@lists.postgresql.org; Mon, 21 Jun 2021 04:55:02 +0000 Received: by mail-pj1-x1029.google.com with SMTP id bb20so5022510pjb.3 for ; Sun, 20 Jun 2021 21:54:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=WpAR7Js+GqmgQgt0l4u28AuzYpjKwM0uR3MhzxwGkm8=; b=VE6b5dCSa5op2aABBz4r33h7H8z5ABsz9TKHGASTkJlRn5azmhOpsaL9QTrPnxABVI YgBfpUhbMJ2qFokrK1//QoxWipnKuEOchgpdM29kX3bzkmmpTvTBAgJAWT/e4SfR10Of iKnxwMy/ipUDxcbtgGR5oVKylGiG5ysAg1NJZscUwWdG4PRYANjY7zBl4uf+RtY2p1hT X5mJcopseuEN8ii6Y/MGnAE0pCWnit2JGtQ9dfPPZEqtlM9Wo/dmbcqdMs2D6Qe5jgon xxHohj3y/Xww8571UQbuemLyKnHo+MctvaYLvlN8jVaevSr33hW2W8G+5fDnIj8wYU6e PH4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=WpAR7Js+GqmgQgt0l4u28AuzYpjKwM0uR3MhzxwGkm8=; b=TNnLWOUi+DH5bElxyXEw8AVortXwIBJ3cCW6+5kvo8O4NqKNAmclBii7Dadob5Hgsa WuFMsolflSMx/MmWdNsGhi72/vHCyewXVx2UL4PEDBVM2U3/cJPNvcGDSGZgQotJN3y3 wP5qhD0YVzBKsYA9mqYRKJKrmb1qe6UO5lH7TKhn3kd5wnL2upHzxMS3TQAg1FS7T5QQ kgwdZixXcc3F6YMlvjHfwGV7NFqqVm+hfvZVOUklyx+mHaHQfiLenjtwurtiTKTCvx7A bFp52/3uyxpqfun6RDE7Jjuecph37XuSE+F6J8sA+Hv85yYzYogfa0iuuX4bPpQsvD02 3yWA== X-Gm-Message-State: AOAM533j5zOJ/kF3qasSNdVGnMuzOjLl3iPAaILNMtLiUHkzSIzt9NPm zktuJfkg/sIvJEEMJFwzXzpiaxCYoi7Y1HTFAbYL/FMRh2u8mpcU54AfPeAldjTDgBW8wbUoDes 7RVmHUXs0R5aBA7JZE/jcrcW84+iPT4DVg7+7GHhGZTgeuasq4U4tZsImbYskpJ9J0c5WZxnaRf FnAXfgvYtXPvP+nxYTOxergvh95OGSIxd1XgbzTMfAZ3C0DGR2Ii6w X-Google-Smtp-Source: ABdhPJyqJ4PYYuBmFuc8bmYcKV7Yjpy3E2ieDs83hZ6sCf77hc3T1vS0JGS0JcKC0vEUVBYYT2AyXQ== X-Received: by 2002:a17:902:d705:b029:11d:9bb6:a3da with SMTP id w5-20020a170902d705b029011d9bb6a3damr16195266ply.33.1624251295661; Sun, 20 Jun 2021 21:54:55 -0700 (PDT) Received: from ?IPv6:2600:6c50:157f:eb87:312a:3853:88ca:1561? ([2600:6c50:157f:eb87:312a:3853:88ca:1561]) by smtp.gmail.com with ESMTPSA id f21sm3248372pjp.39.2021.06.20.21.54.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Jun 2021 21:54:55 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.6\)) Subject: Re: Optionally automatically disable logical replication subscriptions on error From: Mark Dilger In-Reply-To: Date: Sun, 20 Jun 2021 21:54:53 -0700 Cc: Masahiko Sawada , "Smith, Peter" , PostgreSQL Hackers Content-Transfer-Encoding: quoted-printable Message-Id: <14738A39-8000-463E-A0BA-6729930A32DA@enterprisedb.com> References: To: Amit Kapila X-Mailer: Apple Mail (2.3608.120.23.2.6) X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On Jun 20, 2021, at 8:09 PM, Amit Kapila = wrote: >=20 > Because currently, we don't proceed after an error unless it is > resolved. Why do you think there could be multiple such transactions? Just as one example, if the subscriber has a unique index that the = publisher lacks, any number of transactions could add non-unique data = that then fails to apply on the subscriber. My patch took the view that = the user should figure out how to get the subscriber side consistent = with the publisher side, but if you instead take the approach that = problematic commits should be skipped, it would seem that arbitrarily = many such transactions could be committed on the publisher side. =E2=80=94 Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company