Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqjt5-0004Yn-N7 for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Mar 2017 17:17:31 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cqjt5-0000hv-8e for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Mar 2017 17:17:31 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cqjra-0005ZS-RF for pgsql-hackers@postgresql.org; Wed, 22 Mar 2017 17:15:58 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cqjrY-0004xH-6o for pgsql-hackers@postgresql.org; Wed, 22 Mar 2017 17:15:57 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v2MHFf7l014760; Wed, 22 Mar 2017 13:15:41 -0400 From: Tom Lane To: Andres Freund cc: Heikki Linnakangas , Tomas Vondra , pgsql-hackers@postgresql.org Subject: Re: WIP: Faster Expression Processing v4 In-reply-to: <20170322145240.vt2iolwt6vpmx33z@alap3.anarazel.de> References: <20170307030137.lpo4japv5oqgbqpz@alap3.anarazel.de> <2090fd00-4dec-7b42-f700-64308958504c@2ndquadrant.com> <20170313080351.4g5oubxcj4xj5y7t@alap3.anarazel.de> <20170314065259.ffef4tfhgbsaieoe@alap3.anarazel.de> <69b7bb0e-8dab-3d39-1a89-3c6ab6409f64@iki.fi> <20170314224706.nxvtapenky6eom3z@alap3.anarazel.de> <13062.1489622943@sss.pgh.pa.us> <20170320062511.hp5qeurtxrwsvfxr@alap3.anarazel.de> <31150.1490193666@sss.pgh.pa.us> <20170322145240.vt2iolwt6vpmx33z@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Wed, 22 Mar 2017 07:52:40 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <14758.1490202941.1@sss.pgh.pa.us> Date: Wed, 22 Mar 2017 13:15:41 -0400 Message-ID: <14759.1490202941@sss.pgh.pa.us> X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org BTW, I'm fairly concerned by what you did in nodeTidscan.c, ie delaying compile of the TID expressions until TidListCreate. I think that probably fails for cases involving, eg, subplans in the expressions; we need subplans to get linked to the parent node, and this way won't do it till (maybe) too late. Barring objection I'm going to rearrange that so that we still do the compile part at executor start. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers