From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
cc: Alexander Lakhin <exclusion@gmail.com>,
 Andres Freund <andres@anarazel.de>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Noah Misch <noah@leadboat.com>,
        Jacob Champion <jacob.champion@enterprisedb.com>,
        Denis Laxalde <denis.laxalde@dalibo.com>,
        vignesh C <vignesh21@gmail.com>,
 Thomas Munro <thomas.munro@gmail.com>,
        Greg Stark <stark@mit.edu>,
        "Gregory Stark (as CFM)" <stark.cfm@gmail.com>,
        Daniel Gustafsson <daniel@yesql.se>,
        Peter Eisentraut <peter@eisentraut.org>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Robert Haas <robertmhaas@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Etsuro Fujita <etsuro.fujita@gmail.com>
Subject: Re: [EXTERNAL] Re: Add non-blocking version of PQcancel
In-reply-to: 
 <CAGECzQSc=hQ5tsHG3Ep48LXixUCPvX0AXbsE-H+aYZ6AVO6t0w@mail.gmail.com>
References: <202407221126.vyw5q3h4nyoh@alvherre.pgsql>
 <5ea25e4d-1ee2-b9bf-7806-119ffa658826@gmail.com>
 <578934.1725045685@sss.pgh.pa.us>
 <CAGECzQQZi_po92DSgo75vmM-KxG2zMGzo-tt+Z+85w3BgL89ug@mail.gmail.com>
 <584811.1725048717@sss.pgh.pa.us> <591893.1725051309@sss.pgh.pa.us>
 <37c3bd11-7321-fe58-99ca-bc15a67c08cc@gmail.com>
 <c68225b4-fce9-3425-1534-a21a815d5846@gmail.com>
 <colnv3lzzmc53iu5qoawynr6qq7etn47lmggqr65ddtpjliq5d@glkveb4m6nop>
 <2947163.1731810791@sss.pgh.pa.us>
 <8f280cbd-8450-87ea-f0f7-ab4932af5750@gmail.com>
 <321476.1732152654@sss.pgh.pa.us>
 <CAGECzQQFvsuBcT1Bu3eDWDWuxt=GT0MsGJJKK_5og51Rk-4q7Q@mail.gmail.com>
 <480238.1732235854@sss.pgh.pa.us>
 <CAGECzQSc=hQ5tsHG3Ep48LXixUCPvX0AXbsE-H+aYZ6AVO6t0w@mail.gmail.com>
Comments: In-reply-to Jelte Fennema-Nio <postgres@jeltef.nl>
	message dated "Fri, 22 Nov 2024 10:19:16 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1479860.1734984940.1@sss.pgh.pa.us>
Date: Mon, 23 Dec 2024 15:15:40 -0500
Message-ID: <1479861.1734984940@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1479861.1734984940%40sss.pgh.pa.us>
Precedence: bulk

Jelte Fennema-Nio <postgres@jeltef.nl> writes:
> On Fri, 22 Nov 2024 at 01:37, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> How would we do that?  libpqsrv_cancel is not chartered to wait around
>> for the results of the cancel, and I'm not even sure that it could
>> know what to check for.

> Ah yeah, you're right. I got confused by the two timeouts (the one to
> wait for the response of the cancel request itself, and the one to
> wait for the running query to actually be cancelled).

Not having heard any better ideas, I pushed that to HEAD and v17
(with the renaming you suggested).

			regards, tom lane