From: Tom Lane <tgl@sss.pgh.pa.us>
To: Matthew Stickney <mtstickney@gmail.com>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] (Windows) psql echoes password when reading from pipe
In-reply-to: <502a1fff-862b-da52-1031-f68df6ed5a2d@gmail.com>
References: <502a1fff-862b-da52-1031-f68df6ed5a2d@gmail.com>
Comments: In-reply-to Matthew Stickney <mtstickney@gmail.com>
	message dated "Tue, 22 May 2018 00:27:48 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <14852.1527015354.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 22 May 2018 14:55:54 -0400
Message-ID: <14853.1527015354@sss.pgh.pa.us>
Precedence: bulk

Matthew Stickney <mtstickney@gmail.com> writes:
> On windows, if you pipe data to psql, the password prompt correctly =

> reads from and writes to the console, but the password text is echoed to=
 =

> the console. This is because echoing is disabled on the handle for =

> stdin, but as part of a pipeline stdin doesn't refer to the console. =

> I've attached a patch that gets a handle to the console's input buffer =

> by opening CONIN$ instead, which corrects the problem.

Thanks for the report and patch!

I know zip about Windows coding, but I can't help comparing this:

-		t =3D GetStdHandle(STD_INPUT_HANDLE);
+		t =3D CreateFile("CONIN$", GENERIC_READ | GENERIC_WRITE, FILE_SHARE_REA=
D | FILE_SHARE_WRITE, NULL, OPEN_EXISTING, 0, NULL);

to the code a little bit above:

	termin =3D fopen("CONIN$", "r");

Is it possible to operate on "termin" instead of doing a second open
(which might fail, which we are failing to cope with :-()?

			regards, tom lane