Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccUs1-0000bl-Nc for pgsql-hackers@arkaria.postgresql.org; Sat, 11 Feb 2017 10:25:33 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1ccUs1-0007pJ-7c for pgsql-hackers@arkaria.postgresql.org; Sat, 11 Feb 2017 10:25:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ccUrz-0007nn-9P for pgsql-hackers@postgresql.org; Sat, 11 Feb 2017 10:25:31 +0000 Received: from gauss.credativ.com ([93.94.130.89]) by magus.postgresql.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1ccUrt-0002tV-0j for pgsql-hackers@postgresql.org; Sat, 11 Feb 2017 10:25:30 +0000 Received: from gauss.credativ.com (localhost [127.0.0.1]) by gauss.credativ.com (Postfix) with ESMTP id AB37D1E18EB; Sat, 11 Feb 2017 11:25:22 +0100 (CET) Received: from fock (ppp-88-217-106-205.dynamic.mnet-online.de [88.217.106.205]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mba@gauss.credativ.com) by gauss.credativ.com (Postfix) with ESMTPSA id 0ADDF1E15BC; Sat, 11 Feb 2017 11:25:21 +0100 (CET) Message-ID: <1486808720.24568.103.camel@credativ.de> Subject: Re: gitlab post-mortem: pg_basebackup waiting for checkpoint From: Michael Banck To: Magnus Hagander Cc: Pg Hackers Date: Sat, 11 Feb 2017 11:25:20 +0100 In-Reply-To: References: <1486805889.24568.96.camel@credativ.de> Organization: credativ GmbH Content-Type: multipart/mixed; boundary="=-6dU5ciPIYVkr/JN2Zynf" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org --=-6dU5ciPIYVkr/JN2Zynf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hi, Am Samstag, den 11.02.2017, 11:07 +0100 schrieb Magnus Hagander: > As for the code, while I haven't tested it, isn't the "checkpoint > completed" message in the wrong place? Doesn't PQsendQuery() complete > immediately, and the check needs to be put *after* the PQgetResult() > call? I guess you're right, I've moved it further down. There is in fact a message about the xlog location (unless you switch off wal entirely), but having another one right before that mentioning the completed checkpoint sounds ok to me. There's also some inconsistencies around which messages are prepended with "pg_basebackup: " and which are translatable; I guess all messages printed on --verbose should be translatable? Also, as almost all messages have a "pg_basebackup: " prefix, I've added it to the rest. Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.banck@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer --=-6dU5ciPIYVkr/JN2Zynf Content-Disposition: attachment; filename="pg_basebackup_v2.patch" Content-Type: text/x-patch; name="pg_basebackup_v2.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yZWYvcGdfYmFzZWJhY2t1cC5z Z21sIGIvZG9jL3NyYy9zZ21sL3JlZi9wZ19iYXNlYmFja3VwLnNnbWwKaW5k ZXggYzlkZDYyYy4uYTI5OGU1YyAxMDA2NDQKLS0tIGEvZG9jL3NyYy9zZ21s L3JlZi9wZ19iYXNlYmFja3VwLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL3Jl Zi9wZ19iYXNlYmFja3VwLnNnbWwKQEAgLTY2MCw2ICs2NjAsMTQgQEAgUG9z dGdyZVNRTCBkb2N1bWVudGF0aW9uCiAgIDx0aXRsZT5Ob3RlczwvdGl0bGU+ CiAKICAgPHBhcmE+CisgICBBdCB0aGUgYmVnaW5uaW5nIG9mIHRoZSBiYWNr dXAsIGEgY2hlY2twb2ludCBuZWVkcyB0byBiZSB3cml0dGVuIG9uIHRoZQor ICAgc2VydmVyIHRoZSBiYWNrdXAgaXMgdGFrZW4gZnJvbS4gIEVzcGVjaWFs bHkgaWYgdGhlIG9wdGlvbgorICAgPGxpdGVyYWw+LS1jaGVja3BvaW50PWZh c3Q8L2xpdGVyYWw+IGlzIG5vdCB1c2VkLCB0aGlzIGNhbiB0YWtlIHNvbWUg dGltZQorICAgZHVyaW5nIHdoaWNoIDxhcHBsaWNhdGlvbj5wZ19iYXNlYmFj a3VwPC9hcHBsaWNhdGlvbj4gd2lsbCBiZSBpZGxlIG9uIHRoZQorICAgc2Vy dmVyIGl0IGlzIHJ1bm5pbmcgb24uCisgIDwvcGFyYT4KKworICA8cGFyYT4K ICAgIFRoZSBiYWNrdXAgd2lsbCBpbmNsdWRlIGFsbCBmaWxlcyBpbiB0aGUg ZGF0YSBkaXJlY3RvcnkgYW5kIHRhYmxlc3BhY2VzLAogICAgaW5jbHVkaW5n IHRoZSBjb25maWd1cmF0aW9uIGZpbGVzIGFuZCBhbnkgYWRkaXRpb25hbCBm aWxlcyBwbGFjZWQgaW4gdGhlCiAgICBkaXJlY3RvcnkgYnkgdGhpcmQgcGFy dGllcywgZXhjZXB0IGNlcnRhaW4gdGVtcG9yYXJ5IGZpbGVzIG1hbmFnZWQg YnkKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfYmFzZWJhY2t1cC9wZ19iYXNl YmFja3VwLmMgYi9zcmMvYmluL3BnX2Jhc2ViYWNrdXAvcGdfYmFzZWJhY2t1 cC5jCmluZGV4IGI2NDYzZmEuLjg3NGI2ZDYgMTAwNjQ0Ci0tLSBhL3NyYy9i aW4vcGdfYmFzZWJhY2t1cC9wZ19iYXNlYmFja3VwLmMKKysrIGIvc3JjL2Jp bi9wZ19iYXNlYmFja3VwL3BnX2Jhc2ViYWNrdXAuYwpAQCAtMTc1NCw2ICsx NzU0LDExIEBAIEJhc2VCYWNrdXAodm9pZCkKIAlpZiAobWF4cmF0ZSA+IDAp CiAJCW1heHJhdGVfY2xhdXNlID0gcHNwcmludGYoIk1BWF9SQVRFICV1Iiwg bWF4cmF0ZSk7CiAKKwlpZiAodmVyYm9zZSkKKwkJZnByaW50ZihzdGRlcnIs CisJCQkJXygiJXM6IGluaXRpYXRpbmcgYmFzZSBiYWNrdXAsIHdhaXRpbmcg Zm9yIGNoZWNrcG9pbnQgdG8gY29tcGxldGVcbiIpLAorCQkJCXByb2duYW1l KTsKKwogCWJhc2Via3AgPQogCQlwc3ByaW50ZigiQkFTRV9CQUNLVVAgTEFC RUwgJyVzJyAlcyAlcyAlcyAlcyAlcyAlcyIsCiAJCQkJIGVzY2FwZWRfbGFi ZWwsCkBAIC0xNzkxLDYgKzE3OTYsOSBAQCBCYXNlQmFja3VwKHZvaWQpCiAK IAlzdHJsY3B5KHhsb2dzdGFydCwgUFFnZXR2YWx1ZShyZXMsIDAsIDApLCBz aXplb2YoeGxvZ3N0YXJ0KSk7CiAKKwlpZiAodmVyYm9zZSkKKwkJZnByaW50 ZihzdGRlcnIsIF8oIiVzOiBjaGVja3BvaW50IGNvbXBsZXRlZFxuIiksIHBy b2duYW1lKTsKKwogCS8qCiAJICogOS4zIGFuZCBsYXRlciBzZW5kcyB0aGUg VExJIG9mIHRoZSBzdGFydGluZyBwb2ludC4gV2l0aCBvbGRlciBzZXJ2ZXJz LAogCSAqIGFzc3VtZSBpdCdzIHRoZSBzYW1lIGFzIHRoZSBsYXRlc3QgdGlt ZWxpbmUgcmVwb3J0ZWQgYnkKQEAgLTE4MDQsOCArMTgxMiw4IEBAIEJhc2VC YWNrdXAodm9pZCkKIAlNZW1TZXQoeGxvZ2VuZCwgMCwgc2l6ZW9mKHhsb2dl bmQpKTsKIAogCWlmICh2ZXJib3NlICYmIGluY2x1ZGV3YWwgIT0gTk9fV0FM KQotCQlmcHJpbnRmKHN0ZGVyciwgXygidHJhbnNhY3Rpb24gbG9nIHN0YXJ0 IHBvaW50OiAlcyBvbiB0aW1lbGluZSAldVxuIiksCi0JCQkJeGxvZ3N0YXJ0 LCBzdGFydHRsaSk7CisJCWZwcmludGYoc3RkZXJyLCBfKCIlczogdHJhbnNh Y3Rpb24gbG9nIHN0YXJ0IHBvaW50OiAlcyBvbiB0aW1lbGluZSAldVxuIiks CisJCQkJcHJvZ25hbWUsIHhsb2dzdGFydCwgc3RhcnR0bGkpOwogCiAJLyoK IAkgKiBHZXQgdGhlIGhlYWRlcgpAQCAtMTkwNyw3ICsxOTE1LDcgQEAgQmFz ZUJhY2t1cCh2b2lkKQogCX0KIAlzdHJsY3B5KHhsb2dlbmQsIFBRZ2V0dmFs dWUocmVzLCAwLCAwKSwgc2l6ZW9mKHhsb2dlbmQpKTsKIAlpZiAodmVyYm9z ZSAmJiBpbmNsdWRld2FsICE9IE5PX1dBTCkKLQkJZnByaW50ZihzdGRlcnIs ICJ0cmFuc2FjdGlvbiBsb2cgZW5kIHBvaW50OiAlc1xuIiwgeGxvZ2VuZCk7 CisJCWZwcmludGYoc3RkZXJyLCBfKCIlczogdHJhbnNhY3Rpb24gbG9nIGVu ZCBwb2ludDogJXNcbiIsIHByb2duYW1lLCB4bG9nZW5kKTsKIAlQUWNsZWFy KHJlcyk7CiAKIAlyZXMgPSBQUWdldFJlc3VsdChjb25uKTsKQEAgLTIwNDgs NyArMjA1Niw3IEBAIEJhc2VCYWNrdXAodm9pZCkKIAl9CiAKIAlpZiAodmVy Ym9zZSkKLQkJZnByaW50ZihzdGRlcnIsICIlczogYmFzZSBiYWNrdXAgY29t cGxldGVkXG4iLCBwcm9nbmFtZSk7CisJCWZwcmludGYoc3RkZXJyLCBfKCIl czogYmFzZSBiYWNrdXAgY29tcGxldGVkXG4pIiwgcHJvZ25hbWUpOwogfQog CiAK --=-6dU5ciPIYVkr/JN2Zynf Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --=-6dU5ciPIYVkr/JN2Zynf--