Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M336471=pgsql-hackers-arkari@postgresql.org>)
	id 1dvoGE-00076G-2h
	for pgsql-hackers@arkaria.postgresql.org; Sat, 23 Sep 2017 17:30:38 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M336471=pgsql-hackers-arkari@postgresql.org>)
	id 1dvoGD-0001UP-Ln
	for pgsql-hackers@arkaria.postgresql.org; Sat, 23 Sep 2017 17:30:37 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1dvoEf-00075o-VG
	for pgsql-hackers@postgresql.org; Sat, 23 Sep 2017 17:29:02 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1dvoEd-0008RP-1P
	for pgsql-hackers@postgresql.org; Sat, 23 Sep 2017 17:29:01 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v8NHSuVJ014872;
	Sat, 23 Sep 2017 13:28:56 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
        PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: Rethinking autovacuum.c memory handling
In-reply-to: 
 <CAB7nPqTosuvT2Pjz5136jAi2+h0gGsYynuUP52Ejrw=JKXxi-Q@mail.gmail.com>
References: <13849.1506114543@sss.pgh.pa.us>
 <CAB7nPqTosuvT2Pjz5136jAi2+h0gGsYynuUP52Ejrw=JKXxi-Q@mail.gmail.com>
Comments: In-reply-to Michael Paquier <michael.paquier@gmail.com>
	message dated "Sat, 23 Sep 2017 19:26:25 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <14870.1506187736.1@sss.pgh.pa.us>
Date: Sat, 23 Sep 2017 13:28:56 -0400
Message-ID: <14871.1506187736@sss.pgh.pa.us>
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Michael Paquier <michael.paquier@gmail.com> writes:
> I have spent some time looking at your patch and testing it. This
> looks sane. A small comment that I have would be to add an assertion
> at the top of perform_work_item to be sure that it is called in the
> memory context of AutovacMemCxt.

Done like that, thanks for reviewing!

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers