Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hpeZC-0005kR-Fr
	for pgsql-hackers@arkaria.postgresql.org; Mon, 22 Jul 2019 20:05:50 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hpeZA-0005Hf-Rs
	for pgsql-hackers@arkaria.postgresql.org; Mon, 22 Jul 2019 20:05:48 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hpeZA-0005Dx-H5
	for pgsql-hackers@lists.postgresql.org; Mon, 22 Jul 2019 20:05:48 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hpeZ3-0003cE-Kh
	for pgsql-hackers@postgresql.org; Mon, 22 Jul 2019 20:05:48 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x6MK5aq9014872;
	Mon, 22 Jul 2019 16:05:36 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Dmitry Dolgov <9erthalion6@gmail.com>,
        Thomas Munro <thomas.munro@gmail.com>
Subject: Re: errbacktrace
In-reply-to: <3814a094-7dcd-106b-d2ad-7ef78f563356@2ndquadrant.com>
References: <20190708162851.GA11054@alvherre.pgsql>
 <de6cb49b-1969-66f5-ac71-fbff5fd3be25@2ndquadrant.com>
 <3814a094-7dcd-106b-d2ad-7ef78f563356@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Mon, 22 Jul 2019 20:19:26 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <14870.1563825935.1@sss.pgh.pa.us>
Date: Mon, 22 Jul 2019 16:05:35 -0400
Message-ID: <14871.1563825935@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> Here is an updated patch without the libunwind support, some minor
> cleanups, documentation, and automatic back traces from assertion failures.

Just noticing that ExceptionalCondition has an "fflush(stderr);"
in front of what you added --- perhaps you should also add one
after the backtrace_symbols_fd call?  It's not clear to me that
that function guarantees to fflush, nor do I want to assume that
abort() does.

			regards, tom lane