From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: "debug_invalidate_system_caches_always" is too long
In-reply-to: <20210704211234.GD2421985@rfd.leadboat.com>
References: <1374320.1625430433@sss.pgh.pa.us>
 <20210704211234.GD2421985@rfd.leadboat.com>
Comments: In-reply-to Noah Misch <noah@leadboat.com>
	message dated "Sun, 04 Jul 2021 14:12:34 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1492831.1625512421.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 05 Jul 2021 15:13:41 -0400
Message-ID: <1492832.1625512421@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1492832.1625512421%40sss.pgh.pa.us>
Precedence: bulk

Noah Misch <noah@leadboat.com> writes:
> On Sun, Jul 04, 2021 at 04:27:13PM -0400, Tom Lane wrote:
>> However, I think we should also give serious consideration to
>> "debug_clobber_cache" or "debug_clobber_cache_always" for continuity
>> with past practice (though it still feels like "always" is a good
>> word to lose now).  "debug_clobber_caches" is another reasonable
>> variant.

> https://en.wikipedia.org/wiki/Clobbering refers to cases where storage h=
ad no
> changes to its accessibility but now contains different data.  That does=
n't
> match InvalidateSystemCaches() especially well, so I think dropping that=
 word
> has been a good step.  Some other shorter terms could be debug_flush_cac=
hes,
> debug_rebuild_caches, or debug_expire_caches.  (debug_caches is tempting=
, but
> that may ensnare folks looking for extra logging rather than a big slowd=
own.)

I like "debug_flush_caches" --- it's short and accurate.

			regards, tom lane