From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jelte Fennema <postgres@jeltef.nl>
cc: Andres Freund <andres@anarazel.de>, Peter Geoghegan <pg@bowt.ie>,
        Bruce Momjian <bruce@momjian.us>,
        Magnus Hagander <magnus@hagander.net>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Stephen Frost <sfrost@snowman.net>, Noah Misch <noah@leadboat.com>,
        Jesse Zhang <sbjesse@gmail.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: run pgindent on a regular basis / scripted manner
In-reply-to: 
 <CAGECzQT6ZPzxat21mEH1vmbWn=c-XimReEMwgOooso+=FGW7Dw@mail.gmail.com>
References: 
 <CABUevExkB=+FX5Ht2sU6Tmk1fF0h8LqugW5camQ-r00ftPZoSg@mail.gmail.com>
 <20200814202651.GA31108@alvherre.pgsql>
 <CABUevEwGPPaUtObrDywO+vhpFDTJXO+-aeWJd7D46uXTE2sQpA@mail.gmail.com>
 <CAGECzQQs+hz4uQSmD_8oRLr74GtxpE0iXuYE85+RHAzvkF_yvQ@mail.gmail.com>
 <Y8whOD51K2ZlcaFz@momjian.us>
 <CAH2-Wzn_L_kLCw_OLhpBztKwn_aaM0QLmMmubGK4KSxQyJPkbA@mail.gmail.com>
 <1097305.1674334785@sss.pgh.pa.us>
 <CAH2-WzkHHcPRMj3G1b_dUfY0aR4W4OAHQ9_Z6sDGvL8Ew+aRrA@mail.gmail.com>
 <20230121224312.qmwpagrebidr6hi7@awork3.anarazel.de>
 <CAH2-Wzm0niYBPcN6eX3PzHABfj0dE3fwifo5bdturvMp=9FGqw@mail.gmail.com>
 <20230122094957.x542ojaqgi4lalq4@awork3.anarazel.de>
 <CAGECzQRYjHdNQ-Bq2yrBb-8s3Pjx7pfvYPDdNv9tcvDcscDhbg@mail.gmail.com>
 <CAGECzQQZCnmybVcrf9u=eRq=-0SbE+g4CtVu3ZT4B5axBE7JqQ@mail.gmail.com>
 <1354312.1674415202@sss.pgh.pa.us>
 <CAGECzQT6ZPzxat21mEH1vmbWn=c-XimReEMwgOooso+=FGW7Dw@mail.gmail.com>
Comments: In-reply-to Jelte Fennema <postgres@jeltef.nl>
	message dated "Sun, 22 Jan 2023 22:19:10 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1492902.1674429243.1@sss.pgh.pa.us>
Date: Sun, 22 Jan 2023 18:14:03 -0500
Message-ID: <1492903.1674429243@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1492903.1674429243%40sss.pgh.pa.us>
Precedence: bulk

Jelte Fennema <postgres@jeltef.nl> writes:
> Maybe I'm not understanding your issue correctly, but for such
> a case you could push two commits at the same time.

I don't know that much about git commit hooks, but do they really
only check the final state of a series of commits?

In any case, I'm still down on the idea of checking this in a
commit hook because of the complexity and lack of transparency
of such a check.  If you think your commit is correctly indented,
but the hook (running on somebody else's machine) disagrees,
how are you going to debug that?  I don't want to get into such
a situation, especially since Murphy's law guarantees that it
would mainly bite people under time pressure, like when pushing
a security fix.

			regards, tom lane