Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lICuI-0002r7-Vv for pgsql-hackers@arkaria.postgresql.org; Fri, 05 Mar 2021 16:02:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lICuH-0005bB-Ti for pgsql-hackers@arkaria.postgresql.org; Fri, 05 Mar 2021 16:02:25 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lICuH-0005ay-Mw for pgsql-hackers@lists.postgresql.org; Fri, 05 Mar 2021 16:02:25 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lICuB-0008KL-Kn for pgsql-hackers@postgresql.org; Fri, 05 Mar 2021 16:02:24 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 125G1xGS1494599; Fri, 5 Mar 2021 11:02:00 -0500 From: Tom Lane To: Justin Pryzby cc: Anastasia Lubennikova , Stephen Frost , Magnus Hagander , Peter Eisentraut , Heikki Linnakangas , Ian Lawrence Barwick , pgsql-hackers@postgresql.org Subject: Re: [PATCH] remove deprecated v8.2 containment operators In-reply-to: <20210305031317.GS29832@telsasoft.com> References: <155ecfd8-7ac6-1875-5090-d79a586a8847@enterprisedb.com> <235561.1605220100@sss.pgh.pa.us> <20201113150343.GT16415@tamriel.snowman.net> <20201116205516.GM14024@telsasoft.com> <20201130190611.GY24052@telsasoft.com> <1277206.1606763350@sss.pgh.pa.us> <20210202140557.GT7450@telsasoft.com> <1432461.1614909519@sss.pgh.pa.us> <20210305031317.GS29832@telsasoft.com> Comments: In-reply-to Justin Pryzby message dated "Thu, 04 Mar 2021 21:13:17 -0600" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1494597.1614960119.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 05 Mar 2021 11:01:59 -0500 Message-ID: <1494598.1614960119@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Justin Pryzby writes: > On Thu, Mar 04, 2021 at 08:58:39PM -0500, Tom Lane wrote: >> I'm confused by why this patch is only dropping the operators' >> opclass-membership links. Don't we want to actually DROP OPERATOR >> too? > Okay Pushed. Since hstore already had a new-in-v14 edition, I just added the commands to hstore--1.7--1.8.sql rather than make another update script. (Also, you forgot to drop ~ in that one?) > Also , I think it's unrelated to this patch, but shouldn't these be remo= ved ? Right, done. regards, tom lane