From: Tom Lane <tgl@sss.pgh.pa.us>
To: Corey Huinker <corey.huinker@gmail.com>
cc: Jeff Davis <pgsql@j-davis.com>, Magnus Hagander <magnus@hagander.net>,
        Stephen Frost <sfrost@snowman.net>,
        Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
        Matthias van de Meent <boekewurm+postgres@gmail.com>,
        Peter Smith <smithpb2250@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Tomas Vondra <tomas.vondra@enterprisedb.com>
Subject: Re: Statistics Import and Export
In-reply-to: 
 <CADkLM=diTMqw-9mgBRdHCeh1TgVLgFM4sR-b9VzO=8mDn3VWqw@mail.gmail.com>
References: <Zei1xMGH8SJS9yoc@tamriel.snowman.net>
 <54f190b6c757da2a33cce811949e9dd9601fcba7.camel@j-davis.com>
 <1632327b74a734f8c434eb75e824160d2b06a697.camel@j-davis.com>
 <CADkLM=dOUfTtpmE70mx5SmdEs11hic61G-wPa45pB1iC3NRABg@mail.gmail.com>
 <16412b8b7ae443cb7470006beff3011927048860.camel@j-davis.com>
 <CADkLM=cq1n2wbxhV23pOeUKReBPZxZyELDsDJ3VAxkYBSVAe0g@mail.gmail.com>
 <CADkLM=d_WYoFq75eoNHso+9EFDi=Q2BtCmxQYMjrgLL4=v5dxw@mail.gmail.com>
 <1b1bd1ec39ab3de09a17bf7b241021067e5bd63c.camel@j-davis.com>
 <CADkLM=eJXPQD=pWwwm+4Y48haiMmznB8dCECNMrwr59niY8ESw@mail.gmail.com>
 <2bce855db8259c5672a09f863a307ca07b967b68.camel@j-davis.com>
 <CADkLM=dw=fkvPRmOw74UDYnLzXwkDyMSY1k2jsU5=xXBAj7Mpw@mail.gmail.com>
 <5e94c358caedf2a231dd71624c3578db7227a265.camel@j-davis.com>
 <CADkLM=dztWa9shWHyq=+rS9KvbZQ2v54tnOcYT+g8psf0B7w_A@mail.gmail.com>
 <CADkLM=fFwkd7VbO4SPCyX-2f-fyGraka5J+5fcp1QMrCefu68Q@mail.gmail.com>
 <CADkLM=cioQmOFh98qQmqVEkVPjLYszEhZtNtUbmmNAdHOSr3WQ@mail.gmail.com>
 <718fa933c2c58d0ecc6!
 1995ab5c7ca1fe78d6369.camel@j-davis.com>
 <CADkLM=f9FOu9Z2GT1cbtRaffDvtXyUOuv2HMVw0=phYe2T2D9w@mail.gmail.com>
 <CABUevEz1gLOkWSh_Vd9LQh-JM4i=Mu7PVT9ffc77TmH0Zh3TzA@mail.gmail.com>
 <CADkLM=dTY5bkMB4WO0aTYEOP=re0_QjWfYyPd-A5-BvEQdn9cA@mail.gmail.com>
 <790773.1711910899@sss.pgh.pa.us>
 <8bc6ffe1e5abeac0fdde1a83d95409f0463af013.camel@j-davis.com>
 <1141637.1711994977@sss.pgh.pa.us>
 <CADkLM=f+29F1csUZ=7ic0dPwQgV2C1NJycb8A-rk8GQkxC=Jwg@mail.gmail.com>
 <1215956.1711999455@sss.pgh.pa.us>
 <CADkLM=crgW-p8EpR2QLnmRC7axFXeW-2QbKSb4jpuwoCaYqDEA@mail.gmail.com>
 <1321788.1712005745@sss.pgh.pa.us>
 <CADkLM=fpbw6EC3hW4N-RxwxMcNBH8F+M6atyiOapL-PkgfWZCg@mail.gmail.com>
 <1328631.1712008078@sss.pgh.pa.us>
 <CADkLM=daPdFB8V0tgFxK-dLowFsAEzWRWJHyxij7BG3kBjcouA@mail.gmail.com>
 <7d37175cd5b56ab04940ed6b5a72354ae90783ee.camel@j-davis.com>
 <CADkLM=dFrHKkMeBKwFJz4FsC0vTDmjoc3iy-+cfL=XKBAY5UjA@mail.gmail.com>
 <1841621.1712093467@sss.pgh.pa.us>
 <06286ee47fa4b06b6e7f08da21958d7e35525ed4.camel@j-davis.com> <18!
 46403.1712096333@sss.pgh.pa.us>
 <CADkLM=fXi_3OCTZ+gjKiJLZNHp_hpuBD1cf8QMsWo41bw1kMdg@mail.gmail.com>
 <CADkLM=diTMqw-9mgBRdHCeh1TgVLgFM4sR-b9VzO=8mDn3VWqw@mail.gmail.com>
Comments: In-reply-to Corey Huinker <corey.huinker@gmail.com>
	message dated "Wed, 03 Apr 2024 00:59:10 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <149854.1712164687.1@sss.pgh.pa.us>
Date: Wed, 03 Apr 2024 13:18:07 -0400
Message-ID: <149855.1712164687@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/149855.1712164687%40sss.pgh.pa.us>
Precedence: bulk

Corey Huinker <corey.huinker@gmail.com> writes:
> - functions strive to not ERROR unless absolutely necessary. The biggest
> exposure is the call to array_in().

As far as that goes, it shouldn't be that hard to deal with, at least
not for "soft" errors which hopefully cover most input-function
failures these days.  You should be invoking array_in via
InputFunctionCallSafe and passing a suitably-set-up ErrorSaveContext.
(Look at pg_input_error_info() for useful precedent.)

There might be something to be said for handling all the error
cases via an ErrorSaveContext and use of ereturn() instead of
ereport().  Not sure if it's worth the trouble or not.

			regards, tom lane