Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ts1Pp-00DK5v-6T
	for pgsql-hackers@arkaria.postgresql.org; Tue, 11 Mar 2025 15:21:09 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ts1Pn-000mAY-EY
	for pgsql-hackers@arkaria.postgresql.org; Tue, 11 Mar 2025 15:21:07 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ts1Pn-000m9i-4p
	for pgsql-hackers@lists.postgresql.org; Tue, 11 Mar 2025 15:21:07 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ts1Pj-002FRF-27
	for pgsql-hackers@lists.postgresql.org;
	Tue, 11 Mar 2025 15:21:04 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 52BFL01m1499769;
	Tue, 11 Mar 2025 11:21:00 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@alvh.no-ip.org>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: Printing window function OVER clauses in EXPLAIN
In-reply-to: 
 <CAApHDvpepuvR5jDq0rH_KzKbTA6+LuSWOgWG2thFDwvtnjyk_w@mail.gmail.com>
References: <202503100608.ktmgfoerjfqs@alvherre.pgsql>
 <865427.1741623509@sss.pgh.pa.us>
 <CAApHDvpepuvR5jDq0rH_KzKbTA6+LuSWOgWG2thFDwvtnjyk_w@mail.gmail.com>
Comments: In-reply-to David Rowley <dgrowleyml@gmail.com>
	message dated "Tue, 11 Mar 2025 14:16:07 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1499767.1741706460.1@sss.pgh.pa.us>
Date: Tue, 11 Mar 2025 11:21:00 -0400
Message-ID: <1499768.1741706460@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/1499768.1741706460%40sss.pgh.pa.us>
Precedence: bulk

David Rowley <dgrowleyml@gmail.com> writes:
> The only minor points I noted down while reviewing were 1)
> name_active_windows()'s newname variable could be halved in size and,
> 2) explain.sql's new test could name the window "w1" instead of "w" to
> exercise the name selection code a bit better. Both are minor points,
> but I thought I'd mention them anyway.

Thanks, pushed with those points addressed.

			regards, tom lane