Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\))
Subject: Re: Fix gistkillitems & add regression test to microvacuum
From: Andrey Borodin <x4mmm@yandex-team.ru>
In-Reply-To: <CALdSSPiGnqgvpfQDCydBf-=0hzyUs6Y0o0xNvd53BbcMWTVO=w@mail.gmail.com>
Date: Tue, 27 Jan 2026 12:26:01 +0500
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <14B4E29D-7B08-4972-BE9E-491A8A6A77CF@yandex-team.ru>
References: <CALdSSPgZWX_D8+Fx4YQqRN5eW5iSx_rJdqQhCfdWTvqKXVfJ4w@mail.gmail.com>
 <CALdSSPgPs=gKWkKN0=4yBd49FBY=ijxBz4YGV64vfVMK7YQhpw@mail.gmail.com>
 <CALdSSPiaQptrccvRoHhP3=YqN9-K8duXfLHHm3G=+7FVL8A-Xw@mail.gmail.com>
 <CALdSSPh-QtT8NrhtKsNWwFVF3D4KX6Wy3qs-FPc16c6VAECEyg@mail.gmail.com>
 <CALdSSPgfFWUBc8RoOZe5PmoUGa4LJUDeMTcAT8HwXGCMGJ9uBA@mail.gmail.com>
 <449DFC8A-CF54-493E-9366-AF9C73C782AA@yandex-team.ru>
 <CALdSSPiGnqgvpfQDCydBf-=0hzyUs6Y0o0xNvd53BbcMWTVO=w@mail.gmail.com>
To: Kirill Reshke <reshkekirill@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/14B4E29D-7B08-4972-BE9E-491A8A6A77CF%40yandex-team.ru>
Precedence: bulk


> On 23 Jan 2026, at 16:03, Kirill Reshke <reshkekirill@gmail.com> =
wrote:
>=20
> On Tue, 20 Jan 2026 at 15:30, Andrey Borodin <x4mmm@yandex-team.ru> =
wrote:
>>=20
>>=20
>>=20
>>> On 15 Jan 2026, at 22:59, Kirill Reshke <reshkekirill@gmail.com> =
wrote:
>>>=20
>>> PFA v2 which leaves the test in-place.
>>>=20
>>> Also commit message improvements.
>>=20
>> Yeah, killtuples for GiST root page is broken. Your patch is fixing =
it.
>> I don't think we should backpatch this, the bug is harmless, but for =
master the patch LGTM.
>=20
> Thank you
>=20
>> It would be good to assign so->curBlkno and so->curBlkno together. =
But gistScanPage() is the only place with access to the block number.
>=20
> Sorry, didnt get this take.

Sorry, I meant so->curBlkno and so->numKilled are semantically =
correlated. But it's difficult to assign them together and this does not =
worth refactoring.

>=20
>> +# Test gist, but with fewer rows - that killitems used to be buggy.
>>=20
>> Probably, in this comment we can explicitly say that killitems was =
buggy, but now is fixed.
>>=20
>=20
> Hmm, what would be a good wording here?

I've opened an English dictionary and it says "used to" can be used with =
a meaning "bug was there but it's not anymore".

So the patch is RfC IMO.


Best regards, Andrey Borodin.=