Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\))
Subject: Re: amcheck support for BRIN indexes
From: Andrey Borodin <x4mmm@yandex-team.ru>
In-Reply-To: 
 <CAE7r3MJh4qD3SE5ZvBhz-Ae8F7C=K5ZtzyxZQcbEvV5RZwmRRg@mail.gmail.com>
Date: Wed, 18 Jun 2025 14:39:05 +0300
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <14D6E2AE-3813-4AC7-B42F-6D0E765D551C@yandex-team.ru>
References: 
 <CAE7r3MKZkMwuEeFU5M73Jk3yp+2CBr41a3tfvb3CHym+ysAVEA@mail.gmail.com>
 <CAE7r3MLmGA_DbUFYxNp4L7ODwDyLQ2u_vfdTSXj-QJu79B4iHg@mail.gmail.com>
 <0C842FA2-8ACF-4C81-9F0E-F0BDB479AC28@yandex-team.ru>
 <CAE7r3MJh4qD3SE5ZvBhz-Ae8F7C=K5ZtzyxZQcbEvV5RZwmRRg@mail.gmail.com>
To: Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/14D6E2AE-3813-4AC7-B42F-6D0E765D551C%40yandex-team.ru>
Precedence: bulk


> On 18 Jun 2025, at 11:33, Arseniy Mukhin =
<arseniy.mukhin.dev@gmail.com> wrote:
>=20
> Interesting, I used btree check as reference when started
> writing brin check, and in btree check there 53
> ERRCODE_INDEX_CORRUPTED ereports and only 1 ERRCODE_DATA_CORRUPTED
> ereport. So it was very hard to do, but I managed to pick the wrong
> one. I wonder if this btree check ereport should also be changed to
> ERRCODE_INDEX_CORRUPTED?

It's there in a case of heapallindexes failure. I concur that =
ERRCODE_INDEX_CORRUPTED is more appropriate in that case in =
verify_nbtree.c.
But I recollect Peter explained this code before somewhere in =
pgsql-hackers. And the reasoning was something like "if you lack a tuple =
in unquie constraints - it's almost certainly subsequent constrain =
violation and data loss". But I'm not sure.
And I could not find this discussion in archives.


Best regards, Andrey Borodin.=