Feedback-ID: ie0a040ee:Fastmail
Message-ID: <14f5200e-388d-66ff-9deb-695d1fd40d68@eisentraut.org>
Date: Mon, 3 Jul 2023 16:21:04 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.12.0
Subject: Re: Make uselocale protection more consistent
Content-Language: en-US
To: Tristan Partin <tristan@neon.tech>, Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers@postgresql.org
References: <CTNITWIN1G6L.CFIPH8SYNQQW@gonk>
 <fe6fafd1-8bf3-9307-b1d0-e5074722452a@eisentraut.org>
 <CA+hUKGKkfh3wSC-J2eXd4kb499MCJZCCyiL61-mk641uzTBBAA@mail.gmail.com>
 <CTSKHGN8BPUK.14RF8P15GN4ZM@gonk>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <CTSKHGN8BPUK.14RF8P15GN4ZM@gonk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/14f5200e-388d-66ff-9deb-695d1fd40d68%40eisentraut.org>
Precedence: bulk

On 03.07.23 15:21, Tristan Partin wrote:
>>> I think it would be better to keep HAVE_LOCALE_T as encompassing any of
>>> the various locale_t-using functions, rather than using HAVE_USELOCALE
>>> as a proxy for them.  Otherwise you create weird situations like having
>>> #ifdef HAVE_WCSTOMBS_L inside #ifdef HAVE_USELOCALE, which doesn't make
>>> sense, I think.
>> I propose[1] that we get rid of HAVE_LOCALE_T completely and make
>> "libc" provider support unconditional.  It's standardised, and every
>> target system has it, even Windows.  But Windows doesn't have
>> uselocale().
>>
>> [1]https://www.postgresql.org/message-id/flat/CA%2BhUKGL7CmmzeRhoirzjECmOdABVFTn8fo6gEOaFRF1Oxey6Hw%40mail.gmail.com#aef2f2274b28ff8a36f9b8a598e3cec0
> I think keeping HAVE_USELOCALE is important for the Windows case as
> mentioned. I need it for my localization work where I am ripping out
> setlocale() on non-Windows.

The current code is structured

#ifdef HAVE_LOCALE_T
#ifdef HAVE_WCSTOMBS_L
     wcstombs_l(...);
#else
     uselocale(...);
#endif
#else
     elog(ERROR);
#endif

If you just replace HAVE_LOCALE_T with HAVE_USELOCALE, then this would 
penalize a platform that has wcstombs_l(), but not uselocale().  I think 
the correct structure would be

#if defined(HAVE_WCSTOMBS_L)
     wcstombs_l(...);
#elif defined(HAVE_USELOCALE)
     uselocale(...);
#else
     elog(ERROR);
#endif