From: Antonin Houska <ah@cybertec.at>
To: alvherre@kurilemu.de
cc: "Michael Paquier" <michael@paquier.xyz>,
    "SATYANARAYANA NARLAPURAM" <satyanarlapuram@gmail.com>,
    "L. pgsql-hackers" <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Compressed TOAST data corruption with REPACK CONCURRENTLY
In-reply-to: <6933b6c3-5f6b-4ab6-9e86-dd76015d3d3a@app.fastmail.com>
References: 
 <CAHg+QDeXb9HM2VGKXQedyCp52GzajJK5KOUdNi6oLjsS0nerQw@mail.gmail.com>
 <52301.1776440752@localhost>
 <CAHg+QDf+yGGizLHAOm_q8Y9SR-tuDa4vWYp+riJ1QWnWxeeLQw@mail.gmail.com>
 <aeKnABrX4ShBtHkg@paquier.xyz> <44015.1776685220@localhost>
 <6933b6c3-5f6b-4ab6-9e86-dd76015d3d3a@app.fastmail.com>
Comments: In-reply-to =?us-ascii?Q?=3D=3FUTF-8=3FQ=3F=3DC3=3D81lvaro=5FHer?=
 =?us-ascii?Q?rera=3F=3D?= <alvherre@kurilemu.de>
   message dated "Sat, 25 Apr 2026 18:56:35 +0200."
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Sat, 25 Apr 2026 19:33:38 +0200
Message-ID: <15004.1777138418@localhost>
Archived-At: 
 <https://www.postgresql.org/message-id/15004.1777138418%40localhost>
Precedence: bulk

=C3=81lvaro Herrera <alvherre@kurilemu.de> wrote:

> > ok, this is a patch to enhance the tests. It also simplifies
> > gen_compressible() a bit and adjusts it so it is (hopefully) more relia=
ble in
> > generating compressible values. Now it can be used to reproduce the fix=
 [1].
> >
> > [1] https://www.postgresql.org/message-id/52301.1776440752%40localhost
>=20
> Thanks, I think it looks good, but unfortunately I don't see any problems
> when running this test without your fix (I was assuming that the test wou=
ld
> fail). I didn't immediately understand why.  Do you see any failures?

The enhanced tests should reproduce it (please let me know if they dont):

https://www.postgresql.org/message-id/44015.1776685220%40localhost

--=20
Antonin Houska
Web: https://www.cybertec-postgresql.com