Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oIIav-0000bp-9a
	for pgsql-hackers@arkaria.postgresql.org; Sun, 31 Jul 2022 23:43:37 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oIIau-0005id-4X
	for pgsql-hackers@arkaria.postgresql.org; Sun, 31 Jul 2022 23:43:36 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oIIat-0005iU-RF
	for pgsql-hackers@lists.postgresql.org; Sun, 31 Jul 2022 23:43:35 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oIIao-00054h-3G
	for pgsql-hackers@postgresql.org; Sun, 31 Jul 2022 23:43:35 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 26VNhPKJ1500698;
	Sun, 31 Jul 2022 19:43:25 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Justin Pryzby <pryzby@telsasoft.com>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        pgsql-hackers@postgresql.org
Subject: Re: pg_upgrade errno
In-reply-to: <YucSnskQnxLc4ANF@paquier.xyz>
References: <20220731134135.GY15006@telsasoft.com>
 <YucSnskQnxLc4ANF@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Mon, 01 Aug 2022 08:39:10 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1500696.1659311005.1@sss.pgh.pa.us>
Date: Sun, 31 Jul 2022 19:43:25 -0400
Message-ID: <1500697.1659311005@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/1500697.1659311005%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Sun, Jul 31, 2022 at 08:41:35AM -0500, Justin Pryzby wrote:
>> But errno should be saved before strerror/%m.

> Good catch, Justin.  Will fix on HEAD.

It's been wrong a lot longer than that, no?

			regards, tom lane