From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Jelte Fennema <postgres@jeltef.nl>, Peter Geoghegan <pg@bowt.ie>,
        Bruce Momjian <bruce@momjian.us>,
        Magnus Hagander <magnus@hagander.net>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Stephen Frost <sfrost@snowman.net>, Noah Misch <noah@leadboat.com>,
        Jesse Zhang <sbjesse@gmail.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: run pgindent on a regular basis / scripted manner
In-reply-to: <20230123001518.6hxyiczhn4kadvmf@awork3.anarazel.de>
References: <Y8whOD51K2ZlcaFz@momjian.us> <CAH2-Wzn_L_kLCw_OLhpBztKwn_aaM0QLmMmubGK4KSxQyJPkbA@mail.gmail.com> <1097305.1674334785@sss.pgh.pa.us> <CAH2-WzkHHcPRMj3G1b_dUfY0aR4W4OAHQ9_Z6sDGvL8Ew+aRrA@mail.gmail.com> <20230121224312.qmwpagrebidr6hi7@awork3.anarazel.de> <CAH2-Wzm0niYBPcN6eX3PzHABfj0dE3fwifo5bdturvMp=9FGqw@mail.gmail.com> <20230122094957.x542ojaqgi4lalq4@awork3.anarazel.de> <CAGECzQRYjHdNQ-Bq2yrBb-8s3Pjx7pfvYPDdNv9tcvDcscDhbg@mail.gmail.com> <20230122223806.3sgew6qswhsczae7@awork3.anarazel.de> <1495023.1674430107@sss.pgh.pa.us> <20230123001518.6hxyiczhn4kadvmf@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sun, 22 Jan 2023 16:15:18 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1502503.1674433722.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sun, 22 Jan 2023 19:28:42 -0500
Message-ID: <1502504.1674433722@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1502504.1674433722%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> I think I've proposed this before, but I still think that as long as we =
rely
> on pg_bsd_indent, we should have it be part of our source tree and
> automatically built.  It's no wonder that barely anybody indents their
> patches, given that it requires building pg_bsd_ident in a separate repo=
 (but
> referencing our sourc etree), putting the binary in path, etc.

Hmm ... right offhand, the only objection I can see is that the
pg_bsd_indent files use the BSD 4-clause license, which is not ours.
However, didn't UCB grant a blanket exception years ago that said
that people could treat that as the 3-clause license?  If we could
get past the license question, I agree that doing what you suggest
would be superior to the current situation.

			regards, tom lane