From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: Nisha Moond <nisha.moond412@gmail.com>, Euler Taveira <euler@eulerto.com>,
        Michael Paquier <michael@paquier.xyz>,
        Amit Kapila <amit.kapila16@gmail.com>,
        Alexander Lakhin <exclusion@gmail.com>,
        "Jonathan S. Katz" <jkatz@postgresql.org>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Large expressions in indexes can't be stored (non-TOASTable)
In-reply-to: <aAla1fg-1vPeXNck@nathan>
References: 
 <CAA4eK1LeMM8royHj5UyMBDbspD7+_70AJkV4Uji122hmkn7jOw@mail.gmail.com>
 <Z_WGI4cKoTjhUXrs@nathan>
 <4c2a6100-738e-48cc-8a11-2d85f95ae0ed@app.fastmail.com>
 <Z_X1jfsMrBBNUx4n@paquier.xyz> <Z_bFDNzcqWxatpL-@nathan>
 <18a111db-9f31-449c-a14b-61779a69f344@app.fastmail.com>
 <Z_mHvqVyGjEZhzl7@nathan> <aAZqiKRhUv7-fSpQ@nathan>
 <CABdArM6j03AAX5A2B9TPCZrY1xr+eFpGpzfdOBAww7mZnniUFg@mail.gmail.com>
 <aAfP_bitjVC1bcNV@nathan> <aAla1fg-1vPeXNck@nathan>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Wed, 23 Apr 2025 16:25:41 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1503200.1745444021.1@sss.pgh.pa.us>
Date: Wed, 23 Apr 2025 17:33:41 -0400
Message-ID: <1503201.1745444021@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1503201.1745444021%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> Here is a new version of the patch with this change.

I don't see any comments in this patch that capture the real
reason for removing pg_replication_origin's TOAST table,
namely (IIUC) that we'd like to be able to access that catalog
without a snapshot.  I think it's important to record that
knowledge, because otherwise somebody is likely to think they
can undo this change for $whatever-reason.

			regards, tom lane