From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Subject: Where are we on supporting LLVM's opaque-pointer changes?
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1516593.1681482708.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 14 Apr 2023 10:31:48 -0400
Message-ID: <1516594.1681482708@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1516594.1681482708%40sss.pgh.pa.us>
Precedence: bulk

LLVM 16 is apparently released, because Fedora has started using
it in their rawhide (development) branch, which means Postgres
is failing to build there [1][2]:

../../../../src/include/jit/llvmjit_emit.h: In function 'l_load_gep1':
../../../../src/include/jit/llvmjit_emit.h:123:30: warning: implicit decla=
ration of function 'LLVMBuildGEP'; did you mean 'LLVMBuildGEP2'? [-Wimplic=
it-function-declaration]
  123 |         LLVMValueRef v_ptr =3D LLVMBuildGEP(b, v, &idx, 1, "");
      |                              ^~~~~~~~~~~~
      |                              LLVMBuildGEP2
... etc etc etc ...
leading to lots of
+ERROR:  could not load library "/builddir/build/BUILD/postgresql-15.1/tmp=
_install/usr/lib64/pgsql/llvmjit.so": /builddir/build/BUILD/postgresql-15.=
1/tmp_install/usr/lib64/pgsql/llvmjit.so: undefined symbol: LLVMBuildGEP

I know we've been letting this topic slide, but we are out of runway.
I propose adding this as a must-fix open item for PG 16.

			regards, tom lane

[1] https://bugzilla.redhat.com/show_bug.cgi?id=3D2186381
[2] https://kojipkgs.fedoraproject.org/work/tasks/8408/99938408/build.log