Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjjHb-0001zR-3T for pgsql-hackers@arkaria.postgresql.org; Tue, 04 Apr 2023 16:13:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pjjHZ-0006lz-NK for pgsql-hackers@arkaria.postgresql.org; Tue, 04 Apr 2023 16:13:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjjHZ-0006lp-Do for pgsql-hackers@lists.postgresql.org; Tue, 04 Apr 2023 16:13:17 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pjjHW-000rLy-UP for pgsql-hackers@lists.postgresql.org; Tue, 04 Apr 2023 16:13:16 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 334GDAvk1518710; Tue, 4 Apr 2023 12:13:10 -0400 From: Tom Lane To: "David G. Johnston" cc: Pavel Luzanov , "robertmhaas@gmail.com" , David Zhang , "pgsql-hackers@lists.postgresql.org" Subject: Re: psql: Add role's membership options to the \du+ command In-reply-to: References: <01620d6b-9efe-b199-b619-8450d865ec83@postgrespro.ru> <94ce7392-fa90-bc1c-4dc2-677161bbff58@postgrespro.ru> <20824093-d94f-e5d6-b611-8cec7fc6e95e@postgrespro.ru> <42678ca5-f3c6-db1b-e0c5-c63c3ce8997e@postgrespro.ru> <80fb0807-b55b-ccda-7f74-d7d! 90a553846@postgrespro.ru> Comments: In-reply-to "David G. Johnston" message dated "Mon, 03 Apr 2023 15:06:02 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1518708.1680624790.1@sss.pgh.pa.us> Date: Tue, 04 Apr 2023 12:13:10 -0400 Message-ID: <1518709.1680624790@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk "David G. Johnston" writes: > I've marked this Ready for Committer. Hmm ... not sure I like the proposed output. The 'a', 'i', 's' annotations are short but they don't have much else to recommend them. On the other hand, there's nearby precedent for single-letter abbreviations in ACL displays. Nobody particularly likes those, though. Also, if we're modeling this on ACLs then the display could be further shortened to "(ais)" or the like. Also, the patch is ignoring i18n issues. I suppose if we stick with said single-letter abbreviations we'd not translate them, but the construction "rolename from rolename" ought to be translatable IMO. Perhaps it'd be enough to allow replacement of "from", but I wonder if the phrase order would need to be different in some languages? regards, tom lane