Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erQ2g-0007Or-Jt for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Mar 2018 15:22:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1erQ2f-0000QO-KJ for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Mar 2018 15:22:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erQ2f-0000QE-DY for pgsql-hackers@lists.postgresql.org; Thu, 01 Mar 2018 15:22:45 +0000 Received: from mx2.mailbox.org ([80.241.60.215]) by magus.postgresql.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1erQ2c-0002sc-IH for pgsql-hackers@postgresql.org; Thu, 01 Mar 2018 15:22:44 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx2.mailbox.org (Postfix) with ESMTPS id 4679E412A1 for ; Thu, 1 Mar 2018 16:22:41 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de [80.241.56.117]) (amavisd-new, port 10030) with ESMTP id 4OtCyg8mE39o for ; Thu, 1 Mar 2018 16:22:40 +0100 (CET) Message-ID: <1519917758.6586.8.camel@cybertec.at> Subject: SHOW ALL does not honor pg_read_all_settings membership From: Laurenz Albe To: pgsql-hackers@postgresql.org Date: Thu, 01 Mar 2018 16:22:38 +0100 Organization: Cybertec Content-Type: multipart/mixed; boundary="=-NZT/sa40etrdcheT3ep6" Mime-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --=-NZT/sa40etrdcheT3ep6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit I noticed that commit 25fff40798fc4ac11a241bfd9ab0c45c085e2212 forgot to teach SHOW ALL to show all GUCs when the user belongs to pg_read_all_settings. Patch attached; I think this should be backpatched. Yours, Laurenz Albe --=-NZT/sa40etrdcheT3ep6 Content-Disposition: attachment; filename*0=0001-Teach-SHOW-ALL-to-honor-pg_read_all_settings-members.pat; filename*1=ch Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-Teach-SHOW-ALL-to-honor-pg_read_all_settings-members.patch"; charset="UTF-8" RnJvbSBmM2E5MmE2ZWNjOGRjMTE2YTY4NDNjMWJkNzZhYTVlMmE5Nzc4NWZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h dD4KRGF0ZTogVGh1LCAxIE1hciAyMDE4IDE2OjE4OjA0ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g VGVhY2ggU0hPVyBBTEwgdG8gaG9ub3IgcGdfcmVhZF9hbGxfc2V0dGluZ3MgbWVtYmVyc2hpcAoK VGhpcyB3YXMgYW4gb3ZlcnNpZ2h0IGluIGNvbW1pdCAyNWZmZjQwNzk4ZmM0YWMxMWEyNDFiZmQ5 YWIwYzQ1YzA4NWUyMjEyLgotLS0KIHNyYy9iYWNrZW5kL3V0aWxzL21pc2MvZ3VjLmMgfCA0ICsr LS0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvc3JjL2JhY2tlbmQvdXRpbHMvbWlzYy9ndWMuYyBiL3NyYy9iYWNrZW5kL3V0aWxz L21pc2MvZ3VjLmMKaW5kZXggODdiYTY3NjYxYS4uYThjODMzMGRkZSAxMDA2NDQKLS0tIGEvc3Jj L2JhY2tlbmQvdXRpbHMvbWlzYy9ndWMuYworKysgYi9zcmMvYmFja2VuZC91dGlscy9taXNjL2d1 Yy5jCkBAIC04MDEyLDcgKzgwMTIsNiBAQCBTaG93R1VDQ29uZmlnT3B0aW9uKGNvbnN0IGNoYXIg Km5hbWUsIERlc3RSZWNlaXZlciAqZGVzdCkKIHN0YXRpYyB2b2lkCiBTaG93QWxsR1VDQ29uZmln KERlc3RSZWNlaXZlciAqZGVzdCkKIHsKLQlib29sCQlhbV9zdXBlcnVzZXIgPSBzdXBlcnVzZXIo KTsKIAlpbnQJCQlpOwogCVR1cE91dHB1dFN0YXRlICp0c3RhdGU7CiAJVHVwbGVEZXNjCXR1cGRl c2M7CkBAIC04MDM3LDcgKzgwMzYsOCBAQCBTaG93QWxsR1VDQ29uZmlnKERlc3RSZWNlaXZlciAq ZGVzdCkKIAkJY2hhcgkgICAqc2V0dGluZzsKIAogCQlpZiAoKGNvbmYtPmZsYWdzICYgR1VDX05P X1NIT1dfQUxMKSB8fAotCQkJKChjb25mLT5mbGFncyAmIEdVQ19TVVBFUlVTRVJfT05MWSkgJiYg IWFtX3N1cGVydXNlcikpCisJCQkoKGNvbmYtPmZsYWdzICYgR1VDX1NVUEVSVVNFUl9PTkxZKSAm JgorCQkJICFpc19tZW1iZXJfb2Zfcm9sZShHZXRVc2VySWQoKSwgREVGQVVMVF9ST0xFX1JFQURf QUxMX1NFVFRJTkdTKSkpCiAJCQljb250aW51ZTsKIAogCQkvKiBhc3NpZ24gdG8gdGhlIHZhbHVl cyBhcnJheSAqLwotLSAKMi4xNC4zCgo= --=-NZT/sa40etrdcheT3ep6--