Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1f83J2-0006GH-ON
	for pgsql-hackers@arkaria.postgresql.org; Mon, 16 Apr 2018 12:32:24 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1f83J1-0007hM-JX
	for pgsql-hackers@arkaria.postgresql.org; Mon, 16 Apr 2018 12:32:23 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <laurenz.albe@cybertec.at>)
	id 1f83J1-0007hC-Ca
	for pgsql-hackers@lists.postgresql.org; Mon, 16 Apr 2018 12:32:23 +0000
Received: from mx1.mailbox.org ([80.241.60.212])
	by magus.postgresql.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <laurenz.albe@cybertec.at>)
	id 1f83Iu-0004JO-BQ
	for pgsql-hackers@postgresql.org; Mon, 16 Apr 2018 12:32:22 +0000
Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.mailbox.org (Postfix) with ESMTPS id B4CA4446FD;
	Mon, 16 Apr 2018 14:32:14 +0200 (CEST)
X-Virus-Scanned: amavisd-new at heinlein-support.de
Received: from smtp1.mailbox.org ([80.241.60.240])
	by spamfilter01.heinlein-hosting.de (spamfilter01.heinlein-hosting.de
 [80.241.56.115]) (amavisd-new, port 10030)
	with ESMTP id DcubkjlqLlLX; Mon, 16 Apr 2018 14:32:13 +0200 (CEST)
Message-ID: <1523881930.3779.37.camel@cybertec.at>
Subject: Re: SHOW ALL does not honor pg_read_all_settings membership
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: pgsql-hackers@postgresql.org
Cc: simon@2ndquadrant.com
Date: Mon, 16 Apr 2018 14:32:10 +0200
In-Reply-To: <1519917758.6586.8.camel@cybertec.at>
References: <1519917758.6586.8.camel@cybertec.at>
Organization: Cybertec
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On Thu, 2018-03-01 at 16:22 +0100, I wrote:
> I noticed that commit 25fff40798fc4ac11a241bfd9ab0c45c085e2212 forgot
> to teach SHOW ALL to show all GUCs when the user belongs to pg_read_all_settings.
> 
> Patch attached; I think this should be backpatched.

Now that the dust from the last commitfest is settling, I'll make a second
attempt to attract attention for this small bug fix.

The original commit was Simon's.

Yours,
Laurenz Albe