Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f9U75-0001YH-9Z for pgsql-hackers@arkaria.postgresql.org; Fri, 20 Apr 2018 11:21:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f9U72-0008D9-JY for pgsql-hackers@arkaria.postgresql.org; Fri, 20 Apr 2018 11:21:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f9U72-0008Cr-CE for pgsql-hackers@lists.postgresql.org; Fri, 20 Apr 2018 11:21:56 +0000 Received: from mx2.mailbox.org ([80.241.60.215]) by magus.postgresql.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f9U6x-0006CU-MR for pgsql-hackers@postgresql.org; Fri, 20 Apr 2018 11:21:55 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx2.mailbox.org (Postfix) with ESMTPS id 26A6440E64; Fri, 20 Apr 2018 13:21:50 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter02.heinlein-hosting.de (spamfilter02.heinlein-hosting.de [80.241.56.116]) (amavisd-new, port 10030) with ESMTP id SScZpUtEqm9u; Fri, 20 Apr 2018 13:21:49 +0200 (CEST) Message-ID: <1524223306.2480.6.camel@cybertec.at> Subject: Re: SHOW ALL does not honor pg_read_all_settings membership From: Laurenz Albe To: Michael Paquier Cc: pgsql-hackers@postgresql.org, simon@2ndquadrant.com Date: Fri, 20 Apr 2018 13:21:46 +0200 In-Reply-To: <20180417032858.GD4998@paquier.xyz> References: <1519917758.6586.8.camel@cybertec.at> <1523881930.3779.37.camel@cybertec.at> <20180417032858.GD4998@paquier.xyz> Organization: Cybertec Content-Type: multipart/mixed; boundary="=-LDkHf+e/L2jjp5n86Fhn" Mime-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --=-LDkHf+e/L2jjp5n86Fhn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Michael Paquier wrote: > On Mon, Apr 16, 2018 at 02:32:10PM +0200, Laurenz Albe wrote: > > Now that the dust from the last commitfest is settling, I'll make a second > > attempt to attract attention for this small bug fix. > > > > The original commit was Simon's. > > Thanks for the ping. > > This was new as of v10, so this cannot be listed as an open item still I > have added that under the section for older bugs, because you are right > as far as I can see. > > GetConfigOption is wrong by the way, as restrict_superuser means that > all members of the group pg_read_all_settings can read > GUC_SUPERUSER_ONLY params, and not only superusers, so the comment at > least needs a fix, the variable ought to be renamed as well. Thanks for the review! I agree; here is a patch for that. Yours, Laurenz Albe --=-LDkHf+e/L2jjp5n86Fhn Content-Disposition: attachment; filename="0002-Fix-comments-and-a-parameter-name.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0002-Fix-comments-and-a-parameter-name.patch"; charset="UTF-8" RnJvbSBjZmUwNGVmOTc0ZGJhMzI0YzQ3NTEwYjg1NDU4N2RlNmMzM2UzOWExIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h dD4KRGF0ZTogRnJpLCAyMCBBcHIgMjAxOCAxMzoxMzoyMCArMDIwMApTdWJqZWN0OiBbUEFUQ0hd IEZpeCBjb21tZW50cyBhbmQgYSBwYXJhbWV0ZXIgbmFtZQoKQ29tbWl0IDI1ZmZmNDA3OThmYzRh YzExYTI0MWJmZDlhYjBjNDVjMDg1ZTIyMTIgY2hhbmdlZCB0aGUgc2VtYW50aWNzCm9mIEdldENv bmZpZ09wdGlvbiwgYnV0IGRpZCBub3QgdXBkYXRlIHRoZSBjb21tZW50LgoKQWxzbywgdGhlIHBh cmFtZXRlciBuYW1lIHNob3VsZCBiZXR0ZXIgYmUgY2hhbmdlZC4KCk5vdGVkIGJ5IE1pY2hhZWwg UGFxdWllci4KLS0tCiBzcmMvYmFja2VuZC91dGlscy9taXNjL2d1Yy5jIHwgMTAgKysrKystLS0t LQogc3JjL2luY2x1ZGUvdXRpbHMvZ3VjLmggICAgICB8ICAyICstCiAyIGZpbGVzIGNoYW5nZWQs IDYgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2Vu ZC91dGlscy9taXNjL2d1Yy5jIGIvc3JjL2JhY2tlbmQvdXRpbHMvbWlzYy9ndWMuYwppbmRleCA3 YWNlYzVlYTIxLi5iNTUwMWZkOTQ5IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC91dGlscy9taXNj L2d1Yy5jCisrKyBiL3NyYy9iYWNrZW5kL3V0aWxzL21pc2MvZ3VjLmMKQEAgLTY4NjksMTUgKzY4 NjksMTUgQEAgU2V0Q29uZmlnT3B0aW9uKGNvbnN0IGNoYXIgKm5hbWUsIGNvbnN0IGNoYXIgKnZh bHVlLAogICogdGhpcyBjYW5ub3QgYmUgZGlzdGluZ3Vpc2hlZCBmcm9tIGEgc3RyaW5nIHZhcmlh YmxlIHdpdGggYSBOVUxMIHZhbHVlISksCiAgKiBvdGhlcndpc2UgdGhyb3cgYW4gZXJlcG9ydCBh bmQgZG9uJ3QgcmV0dXJuLgogICoKLSAqIElmIHJlc3RyaWN0X3N1cGVydXNlciBpcyB0cnVlLCB3 ZSBhbHNvIGVuZm9yY2UgdGhhdCBvbmx5IHN1cGVydXNlcnMgY2FuCi0gKiBzZWUgR1VDX1NVUEVS VVNFUl9PTkxZIHZhcmlhYmxlcy4gIFRoaXMgc2hvdWxkIG9ubHkgYmUgcGFzc2VkIGFzIHRydWUK LSAqIGluIHVzZXItZHJpdmVuIGNhbGxzLgorICogSWYgcmVzdHJpY3RfcHJpdmlsZWdlZCBpcyB0 cnVlLCB3ZSBhbHNvIGVuZm9yY2UgdGhhdCBvbmx5IHN1cGVydXNlcnMgYW5kCisgKiBtZW1iZXJz IG9mIHRoZSBwZ19yZWFkX2FsbF9zZXR0aW5ncyByb2xlIGNhbiBzZWUgR1VDX1NVUEVSVVNFUl9P TkxZCisgKiB2YXJpYWJsZXMuICBUaGlzIHNob3VsZCBvbmx5IGJlIHBhc3NlZCBhcyB0cnVlIGlu IHVzZXItZHJpdmVuIGNhbGxzLgogICoKICAqIFRoZSBzdHJpbmcgaXMgKm5vdCogYWxsb2NhdGVk IGZvciBtb2RpZmljYXRpb24gYW5kIGlzIHJlYWxseSBvbmx5CiAgKiB2YWxpZCB1bnRpbCB0aGUg bmV4dCBjYWxsIHRvIGNvbmZpZ3VyYXRpb24gcmVsYXRlZCBmdW5jdGlvbnMuCiAgKi8KIGNvbnN0 IGNoYXIgKgotR2V0Q29uZmlnT3B0aW9uKGNvbnN0IGNoYXIgKm5hbWUsIGJvb2wgbWlzc2luZ19v aywgYm9vbCByZXN0cmljdF9zdXBlcnVzZXIpCitHZXRDb25maWdPcHRpb24oY29uc3QgY2hhciAq bmFtZSwgYm9vbCBtaXNzaW5nX29rLCBib29sIHJlc3RyaWN0X3ByaXZpbGVnZWQpCiB7CiAJc3Ry dWN0IGNvbmZpZ19nZW5lcmljICpyZWNvcmQ7CiAJc3RhdGljIGNoYXIgYnVmZmVyWzI1Nl07CkBA IC02ODkyLDcgKzY4OTIsNyBAQCBHZXRDb25maWdPcHRpb24oY29uc3QgY2hhciAqbmFtZSwgYm9v bCBtaXNzaW5nX29rLCBib29sIHJlc3RyaWN0X3N1cGVydXNlcikKIAkJCQkgZXJybXNnKCJ1bnJl Y29nbml6ZWQgY29uZmlndXJhdGlvbiBwYXJhbWV0ZXIgXCIlc1wiIiwKIAkJCQkJCW5hbWUpKSk7 CiAJfQotCWlmIChyZXN0cmljdF9zdXBlcnVzZXIgJiYKKwlpZiAocmVzdHJpY3RfcHJpdmlsZWdl ZCAmJgogCQkocmVjb3JkLT5mbGFncyAmIEdVQ19TVVBFUlVTRVJfT05MWSkgJiYKIAkJIWlzX21l bWJlcl9vZl9yb2xlKEdldFVzZXJJZCgpLCBERUZBVUxUX1JPTEVfUkVBRF9BTExfU0VUVElOR1Mp KQogCQllcmVwb3J0KEVSUk9SLApkaWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUvdXRpbHMvZ3VjLmgg Yi9zcmMvaW5jbHVkZS91dGlscy9ndWMuaAppbmRleCAzZDEzYTMzYjk0Li5mNDYyZWFiZTU5IDEw MDY0NAotLS0gYS9zcmMvaW5jbHVkZS91dGlscy9ndWMuaAorKysgYi9zcmMvaW5jbHVkZS91dGls cy9ndWMuaApAQCAtMzQ3LDcgKzM0Nyw3IEBAIGV4dGVybiB2b2lkIERlZmluZUN1c3RvbUVudW1W YXJpYWJsZSgKIGV4dGVybiB2b2lkIEVtaXRXYXJuaW5nc09uUGxhY2Vob2xkZXJzKGNvbnN0IGNo YXIgKmNsYXNzTmFtZSk7CiAKIGV4dGVybiBjb25zdCBjaGFyICpHZXRDb25maWdPcHRpb24oY29u c3QgY2hhciAqbmFtZSwgYm9vbCBtaXNzaW5nX29rLAotCQkJCWJvb2wgcmVzdHJpY3Rfc3VwZXJ1 c2VyKTsKKwkJCQlib29sIHJlc3RyaWN0X3ByaXZpbGVnZWQpOwogZXh0ZXJuIGNvbnN0IGNoYXIg KkdldENvbmZpZ09wdGlvblJlc2V0U3RyaW5nKGNvbnN0IGNoYXIgKm5hbWUpOwogZXh0ZXJuIGlu dAlHZXRDb25maWdPcHRpb25GbGFncyhjb25zdCBjaGFyICpuYW1lLCBib29sIG1pc3Npbmdfb2sp OwogZXh0ZXJuIHZvaWQgUHJvY2Vzc0NvbmZpZ0ZpbGUoR3VjQ29udGV4dCBjb250ZXh0KTsKLS0g CjIuMTQuMwoK --=-LDkHf+e/L2jjp5n86Fhn--