Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oKTdl-0005Wq-6H
	for pgsql-hackers@arkaria.postgresql.org; Sat, 06 Aug 2022 23:55:33 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oKTdj-00085G-SJ
	for pgsql-hackers@arkaria.postgresql.org; Sat, 06 Aug 2022 23:55:31 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oKTdj-000856-Io
	for pgsql-hackers@lists.postgresql.org; Sat, 06 Aug 2022 23:55:31 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oKTdh-0001MQ-JV
	for pgsql-hackers@postgresql.org; Sat, 06 Aug 2022 23:55:31 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 276NtPnY152684;
	Sat, 6 Aug 2022 19:55:25 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Andres Freund <andres@anarazel.de>, Andrew Dunstan <andrew@dunslane.net>,
        Robert Haas <robertmhaas@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Cleaning up historical portability baggage
In-reply-to: 
 <CA+hUKGLyGrqbC_YgW_+Fa1mLKev-WGmta1cDC5nVp+iuQ3bE0A@mail.gmail.com>
References: <1662559.1657648462@sss.pgh.pa.us>
 <CA+hUKG+MOzmDkr27ceG8+uwgFxbJUUv699V3VP3DCioQigrf7A@mail.gmail.com>
 <1249825.1658622186@sss.pgh.pa.us>
 <CA+hUKGLryBW4fNYoXzMG9y1e0H-QOTdSiTG46xCr1DNuuPwbeg@mail.gmail.com>
 <CA+hUKGJMcwbzRyfTocfxbPBUhERqKE42d-L22jQ+vpB7an-NjQ@mail.gmail.com>
 <20220804013546.h65najrzig764jar@awork3.anarazel.de>
 <3295936.1659577924@sss.pgh.pa.us>
 <20220804023010.24snkyq3hser5pxq@awork3.anarazel.de>
 <CA+hUKGLjffiULiVs5K4mi8FO5dgfngjKx5n9vZdDzQB9hzfurw@mail.gmail.com>
 <CA+hUKGJJxtpG12XFu6XJRxo+1ZmTrnYwY9_e8FgrVS7K9ar5Mg@mail.gmail.com>
 <20220805210823.u546w4p4wzfany7p@awork3.anarazel.de>
 <CA+hUKGLyGrqbC_YgW_+Fa1mLKev-WGmta1cDC5nVp+iuQ3bE0A@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Sun, 07 Aug 2022 11:47:31 +1200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <152682.1659830125.1@sss.pgh.pa.us>
Date: Sat, 06 Aug 2022 19:55:25 -0400
Message-ID: <152683.1659830125@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/152683.1659830125%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> So what about strtof?  That's gotta be dead code too.  I gather we
> still need commit 72880ac1's HAVE_BUGGY_STRTOF.  From a cursory glance
> at MinGW's implementation, it still has the complained-about
> behaviour, if I've understood the complaint, and if I'm looking at the
> right C runtime[1].

Looks plausible from here.

			regards, tom lane