From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: Noah Misch <noah@leadboat.com>, Andrew Dunstan <andrew@dunslane.net>,
        pgsql-hackers@postgresql.org
Subject: Re: PL_stashcache, or, what's our minimum Perl version?
In-reply-to: <b3624e34-bc92-381e-1e65-b2b34304a927@2ndquadrant.com>
References: <20540.1501210115@sss.pgh.pa.us> <16894.1501392088@sss.pgh.pa.us>
 <20170730154814.GA2636941@rfd.leadboat.com> <22744.1501430710@sss.pgh.pa.us>
 <20170730163054.GA2630977@rfd.leadboat.com> <25937.1501433410@sss.pgh.pa.us>
 <c3ad3515-64e9-f5a1-1f39-d2cb646fcb96@2ndquadrant.com>
 <9072.1501527316@sss.pgh.pa.us>
 <90a92a7d-938e-507a-3bd7-ecd2b4004689@2ndquadrant.com>
 <14432.1501529890@sss.pgh.pa.us>
 <7fbd4508-23c5-f426-d374-6c72e20bbce9@2ndquadrant.com>
 <18305.1501534485@sss.pgh.pa.us>
 <b3624e34-bc92-381e-1e65-b2b34304a927@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Mon, 31 Jul 2017 20:54:28 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <15281.1501553914.1@sss.pgh.pa.us>
Date: Mon, 31 Jul 2017 22:18:34 -0400
Message-ID: <15282.1501553914@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 7/31/17 16:54, Tom Lane wrote:
>> Maybe "which" isn't the best tool for the job, not sure.

> Yeah, "which" is not portable.  This would need a bit more work and
> portability testing.

Fair enough.  This late in beta is probably not the time to be adding new
portability testing needs.  However, I noticed that some places --- not
consistently everywhere --- were solving this with the low-tech method of
just skipping AC_PATH_PROG if the variable is already set.  We could apply
that hack more consistently by inventing a PGAC_PATH_PROGS wrapper macro
as I previously sketched, but for now just defining it as

# Let the user override the search for $1
if test -z "$$1"; then
  AC_PATH_PROGS($@)
fi

(untested, but you get the idea).  In the long run I would like to improve
this to force the supplied value into absolute-path form, but I'd be
content to ship v10 like that.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers