Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvv0p-0003nH-SP for pgsql-hackers@arkaria.postgresql.org; Mon, 08 May 2023 07:10:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pvv0m-0007Fa-CP for pgsql-hackers@arkaria.postgresql.org; Mon, 08 May 2023 07:10:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvv0l-0007FP-V3 for pgsql-hackers@lists.postgresql.org; Mon, 08 May 2023 07:10:20 +0000 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pvv0h-001A57-Sd for pgsql-hackers@lists.postgresql.org; Mon, 08 May 2023 07:10:18 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 436412B06835; Mon, 8 May 2023 03:10:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 08 May 2023 03:10:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1683529812; x=1683537012; bh=kIRm5sqTLakRb O2vKJr1v/xpvwO9+09NTrmCEmTyZ5c=; b=WEdW0M91zwAfpNJNnqiHfKxaxRjyb 4dt8vaa/qW8rLmk9OvNsxgzNQbFwOnNb55WiLiH8HqtlhfbwMUqfcn5HEi4jaL0j Y/i83aenwhBS8jeWPdrSd/63rbidSYOJ+AlxWgg0mCyuaQiMdSqk1WuTHnXk822l 9/rZ3ixo1EcFokzs6eYS27KoDGroBlecdY3bj5mqzs5euAxiw88ocaI8GqjfL+Yu VaEF0lZ8jbPIGF3HWQKEpjsIxDyKXP81Vnup8cs84gxTtfAJB6eHyFLUI5Q/rWF9 EMGqDu+jHdfca+ZG0/+AClfpaY3xdNRUhFliV4DLKaxrZ3ty45u8ZlbAQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefjedguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtkfffgggfuffvvehfhfgjsehmtderredtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnth gvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeutdekheeuhedtvdfg ffehleetfefhieefudeitdffiedtledujefhjedufeffffenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghu thesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 8 May 2023 03:10:11 -0400 (EDT) Content-Type: multipart/mixed; boundary="------------OqDe6mF5zg52UlJ8vpdryz5z" Message-ID: <152e4c2c-36b4-bdc0-1b62-e9f9e8b68adc@enterprisedb.com> Date: Mon, 8 May 2023 09:10:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: SQL:2011 application time Content-Language: en-US To: Paul Jungwirth Cc: Corey Huinker , PostgreSQL Hackers , Jaime Casanova References: <20210904195556.GA10553@ahch-to> <20210911015017.GA8837@ahch-to> <5650d77a-1d73-fd8d-4410-8e97dbeff572@illuminatedcomputing.com> <21964319-46e5-3e47-217b-6ac4169bdf13@enterprisedb.com> <27361388-f5ab-ea36-ea35-41d68a90e60d@illuminatedcomputing.com> From: Peter Eisentraut In-Reply-To: <27361388-f5ab-ea36-ea35-41d68a90e60d@illuminatedcomputing.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------OqDe6mF5zg52UlJ8vpdryz5z Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03.05.23 23:02, Paul Jungwirth wrote: > Thank you again for the review. Here is a patch with most of your > feedback addressed. Sorry it has taken so long! These patches are > rebased up to 1ab763fc22adc88e5d779817e7b42b25a9dd7c9e > (May 3). Here are a few small fixup patches to get your patch set compiling cleanly. Also, it looks like the patches 0002, 0003, and 0004 are not split up correctly. 0002 contains tests using the FOR PORTION OF syntax introduced in 0003, and 0003 uses the function build_period_range() from 0004. --------------OqDe6mF5zg52UlJ8vpdryz5z Content-Type: text/plain; charset=UTF-8; name="0001-fixup-Add-PERIODs.patch" Content-Disposition: attachment; filename="0001-fixup-Add-PERIODs.patch" Content-Transfer-Encoding: base64 RnJvbSA2ZmE4MTliNjc1MjU1YWY3NjNlNTFhNjdkNGQ4Yzg4ZjFkMzkwYjZjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogTW9uLCA4IE1heSAyMDIzIDA4OjQ1OjMyICswMjAwClN1YmplY3Q6 IFtQQVRDSCAxLzNdIGZpeHVwISBBZGQgUEVSSU9EcwoKLS0tCiBkb2Mvc3JjL3NnbWwvcmVm L2FsdGVyX3RhYmxlLnNnbWwgICAgICAgICAgICAgICAgICAgIHwgMiArLQogc3JjL3Rlc3Qv bW9kdWxlcy90ZXN0X2RkbF9kZXBhcnNlL3Rlc3RfZGRsX2RlcGFyc2UuYyB8IDYgKysrKysr CiAyIGZpbGVzIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlm ZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yZWYvYWx0ZXJfdGFibGUuc2dtbCBiL2RvYy9zcmMv c2dtbC9yZWYvYWx0ZXJfdGFibGUuc2dtbAppbmRleCA0ODdmMDlmODhhLi5kNmFlZDNkZmY4 IDEwMDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwvcmVmL2FsdGVyX3RhYmxlLnNnbWwKKysrIGIv ZG9jL3NyYy9zZ21sL3JlZi9hbHRlcl90YWJsZS5zZ21sCkBAIC01ODIsNyArNTgyLDcgQEAg PHRpdGxlPkRlc2NyaXB0aW9uPC90aXRsZT4KICAgICA8L2xpc3RpdGVtPgogICAgPC92YXJs aXN0ZW50cnk+CiAKLSAgIDx2YXJsaXN0ZW50cnk+CisgICA8dmFybGlzdGVudHJ5IGlkPSJz cWwtYWx0ZXJ0YWJsZS1kZXNjLWRyb3AtcGVyaW9kIj4KICAgICA8dGVybT48bGl0ZXJhbD5E Uk9QIFBFUklPRCBGT1I8L2xpdGVyYWw+PC90ZXJtPgogICAgIDxsaXN0aXRlbT4KICAgICAg PHBhcmE+CmRpZmYgLS1naXQgYS9zcmMvdGVzdC9tb2R1bGVzL3Rlc3RfZGRsX2RlcGFyc2Uv dGVzdF9kZGxfZGVwYXJzZS5jIGIvc3JjL3Rlc3QvbW9kdWxlcy90ZXN0X2RkbF9kZXBhcnNl L3Rlc3RfZGRsX2RlcGFyc2UuYwppbmRleCBiN2M2Zjk4NTc3Li42ZjRlNDRkZTNmIDEwMDY0 NAotLS0gYS9zcmMvdGVzdC9tb2R1bGVzL3Rlc3RfZGRsX2RlcGFyc2UvdGVzdF9kZGxfZGVw YXJzZS5jCisrKyBiL3NyYy90ZXN0L21vZHVsZXMvdGVzdF9kZGxfZGVwYXJzZS90ZXN0X2Rk bF9kZXBhcnNlLmMKQEAgLTMwOSw2ICszMDksMTIgQEAgZ2V0X2FsdGVydGFibGVfc3ViY21k aW5mbyhQR19GVU5DVElPTl9BUkdTKQogCQkJY2FzZSBBVF9SZUFkZFN0YXRpc3RpY3M6CiAJ CQkJc3RydHlwZSA9ICIocmUpIEFERCBTVEFUUyI7CiAJCQkJYnJlYWs7CisJCQljYXNlIEFU X0FkZFBlcmlvZDoKKwkJCQlzdHJ0eXBlID0gIkFERCBQRVJJT0QiOworCQkJCWJyZWFrOwor CQkJY2FzZSBBVF9Ecm9wUGVyaW9kOgorCQkJCXN0cnR5cGUgPSAiRFJPUCBQRVJJT0QiOwor CQkJCWJyZWFrOwogCQl9CiAKIAkJaWYgKHN1YmNtZC0+cmVjdXJzZSkKLS0gCjIuNDAuMAoK --------------OqDe6mF5zg52UlJ8vpdryz5z Content-Type: text/plain; charset=UTF-8; name="0002-fixup-Add-PERIODs.patch" Content-Disposition: attachment; filename="0002-fixup-Add-PERIODs.patch" Content-Transfer-Encoding: base64 RnJvbSA4MDllMWZlMTQ1ODk2YjE5MGFhNGMwZWM3MzkwMjA3MWU1Y2NkY2NjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogTW9uLCA4IE1heSAyMDIzIDA5OjA0OjQyICswMjAwClN1YmplY3Q6 IFtQQVRDSCAyLzNdIGZpeHVwISBBZGQgUEVSSU9EcwoKLS0tCiBzcmMvYmFja2VuZC9jYXRh bG9nL21lc29uLmJ1aWxkIHwgMSArCiBzcmMvaW5jbHVkZS9jYXRhbG9nL21lc29uLmJ1aWxk IHwgMSArCiAyIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBh L3NyYy9iYWNrZW5kL2NhdGFsb2cvbWVzb24uYnVpbGQgYi9zcmMvYmFja2VuZC9jYXRhbG9n L21lc29uLmJ1aWxkCmluZGV4IGZhNjYwOWU1NzcuLmM0OTljZDJmNWQgMTAwNjQ0Ci0tLSBh L3NyYy9iYWNrZW5kL2NhdGFsb2cvbWVzb24uYnVpbGQKKysrIGIvc3JjL2JhY2tlbmQvY2F0 YWxvZy9tZXNvbi5idWlsZApAQCAtMjYsNiArMjYsNyBAQCBiYWNrZW5kX3NvdXJjZXMgKz0g ZmlsZXMoCiAgICdwZ19uYW1lc3BhY2UuYycsCiAgICdwZ19vcGVyYXRvci5jJywKICAgJ3Bn X3BhcmFtZXRlcl9hY2wuYycsCisgICdwZ19wZXJpb2QuYycsCiAgICdwZ19wcm9jLmMnLAog ICAncGdfcHVibGljYXRpb24uYycsCiAgICdwZ19yYW5nZS5jJywKZGlmZiAtLWdpdCBhL3Ny Yy9pbmNsdWRlL2NhdGFsb2cvbWVzb24uYnVpbGQgYi9zcmMvaW5jbHVkZS9jYXRhbG9nL21l c29uLmJ1aWxkCmluZGV4IDMxNzliZTA5ZDMuLmM5MmQ0OTI4YTMgMTAwNjQ0Ci0tLSBhL3Ny Yy9pbmNsdWRlL2NhdGFsb2cvbWVzb24uYnVpbGQKKysrIGIvc3JjL2luY2x1ZGUvY2F0YWxv Zy9tZXNvbi5idWlsZApAQCAtNTcsNiArNTcsNyBAQCBjYXRhbG9nX2hlYWRlcnMgPSBbCiAg ICdwZ19jb2xsYXRpb24uaCcsCiAgICdwZ19wYXJhbWV0ZXJfYWNsLmgnLAogICAncGdfcGFy dGl0aW9uZWRfdGFibGUuaCcsCisgICdwZ19wZXJpb2QuaCcsCiAgICdwZ19yYW5nZS5oJywK ICAgJ3BnX3RyYW5zZm9ybS5oJywKICAgJ3BnX3NlcXVlbmNlLmgnLAotLSAKMi40MC4wCgo= --------------OqDe6mF5zg52UlJ8vpdryz5z Content-Type: text/plain; charset=UTF-8; name="0003-fixup-Add-UPDATE-DELETE-FOR-PORTION-OF.patch" Content-Disposition: attachment; filename="0003-fixup-Add-UPDATE-DELETE-FOR-PORTION-OF.patch" Content-Transfer-Encoding: base64 RnJvbSA5NGY0NmRlYWNkZWFhM2RiYWMxZDM5ODg2Nzg5ODFhYzhjZjVmYTlhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogTW9uLCA4IE1heSAyMDIzIDA5OjA1OjA0ICswMjAwClN1YmplY3Q6 IFtQQVRDSCAzLzNdIGZpeHVwISBBZGQgVVBEQVRFL0RFTEVURSBGT1IgUE9SVElPTiBPRgoK LS0tCiBzcmMvYmFja2VuZC91dGlscy9hZHQvbWVzb24uYnVpbGQgfCAxICsKIDEgZmlsZSBj aGFuZ2VkLCAxIGluc2VydGlvbigrKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3V0aWxz L2FkdC9tZXNvbi5idWlsZCBiL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9tZXNvbi5idWlsZApp bmRleCA4NTE1Y2Q5MzY1Li45ZGViMjZmOTUzIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC91 dGlscy9hZHQvbWVzb24uYnVpbGQKKysrIGIvc3JjL2JhY2tlbmQvdXRpbHMvYWR0L21lc29u LmJ1aWxkCkBAIC02NSw2ICs2NSw3IEBAIGJhY2tlbmRfc291cmNlcyArPSBmaWxlcygKICAg J29yYWNsZV9jb21wYXQuYycsCiAgICdvcmRlcmVkc2V0YWdncy5jJywKICAgJ3BhcnRpdGlv bmZ1bmNzLmMnLAorICAncGVyaW9kLmMnLAogICAncGdfbG9jYWxlLmMnLAogICAncGdfbHNu LmMnLAogICAncGdfdXBncmFkZV9zdXBwb3J0LmMnLAotLSAKMi40MC4wCgo= --------------OqDe6mF5zg52UlJ8vpdryz5z--