From: Tom Lane <tgl@sss.pgh.pa.us>
To: jian he <jian.universality@gmail.com>
cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pg_dumpall appendPQExpBuffer construct sql need an white space
In-reply-to: <CACJufxGkvhD_S9hGium08MCVqKqpreyq01NzDqajqYJ=R+xg2Q@mail.gmail.com>
References: <CACJufxGkvhD_S9hGium08MCVqKqpreyq01NzDqajqYJ=R+xg2Q@mail.gmail.com>
Comments: In-reply-to jian he <jian.universality@gmail.com>
	message dated "Thu, 16 Jan 2025 10:53:51 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1531215.1736996399.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 15 Jan 2025 21:59:59 -0500
Message-ID: <1531216.1736996399@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1531216.1736996399%40sss.pgh.pa.us>
Precedence: bulk

jian he <jian.universality@gmail.com> writes:
> in src/bin/pg_dump/pg_dumpall.c
>     appendPQExpBuffer(buf, " FROM pg_auth_members a "
>                       "LEFT JOIN %s ur on ur.oid =3D a.roleid "
>                       "LEFT JOIN %s um on um.oid =3D a.member "
>                       "LEFT JOIN %s ug on ug.oid =3D a.grantor "
>                       "WHERE NOT (ur.rolname ~ '^pg_' AND um.rolname ~ '=
^pg_')"
>                       "ORDER BY 1,2,4", role_catalog, role_catalog,
> role_catalog);

> here "WHERE NOT (ur.rolname ~ '^pg_' AND um.rolname ~ '^pg_')"
> need a white space at the end?

The right paren is its own token in any case, so we don't need
a space for correctness.  You could argue that it'd improve
readability, but who reads pg_dumpall's queries?

			regards, tom lane