From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Remove configure --disable-float4-byval and
 --disable-float8-byval
In-reply-to: <f3e1e576-2749-bbd7-2d57-3f9dcf75255a@2ndquadrant.com>
References: <f3e1e576-2749-bbd7-2d57-3f9dcf75255a@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Thu, 31 Oct 2019 09:50:16 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <15315.1572528990.1@sss.pgh.pa.us>
Date: Thu, 31 Oct 2019 09:36:30 -0400
Message-ID: <15316.1572528990@sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> float4 is now always pass-by-value; the pass-by-reference code path is 
> completely removed.

I think this is OK.

> float8 and related types are now hardcoded to pass-by-value or 
> pass-by-reference depending on whether the build is 64- or 32-bit, as 
> was previously also the default.

I'm less happy with doing this.  It makes it impossible to test the
pass-by-reference code paths without actually firing up a 32-bit
environment.  It'd be fine to document --disable-float8-byval as
a developer-only option (it might be so already), but I don't want
to lose it completely.  I fail to see any advantage in getting rid
of it, anyway, since we do still have to maintain both code paths.

			regards, tom lane