Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fgAgA-0007HX-NF for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Jul 2018 15:17:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fgAg9-0004Hj-7J for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Jul 2018 15:17:17 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fgAg8-0004Hc-QY for pgsql-hackers@lists.postgresql.org; Thu, 19 Jul 2018 15:17:17 +0000 Received: from smtp-fw-4101.amazon.com ([72.21.198.25]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fgAg6-0006aE-84 for pgsql-hackers@postgresql.org; Thu, 19 Jul 2018 15:17:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1532013434; x=1563549434; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=xKgUIXUrZtQgToGv4Dkn4uz9nhTzL2P8LmIgr1eBW4o=; b=jI1PqotqYu5HsUwKjGuH32i1/m5AECzhQm0lQM/N+Ftndxfjzx/fTI7R ngSkXsZzgu748Ttz4TBPPvxcYZvCEeVnZxWYpvtTB4vd1nsnFiXEmNASa j1ZLPfoiRTsLnhRYBfHHe0XABHgsLraG+SMV5q18HJrI2UnKEkFCIbpO2 E=; X-IronPort-AV: E=Sophos;i="5.51,375,1526342400"; d="scan'208";a="729601405" Received: from iad6-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-2b-c300ac87.us-west-2.amazon.com) ([10.124.125.6]) by smtp-border-fw-out-4101.iad4.amazon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 19 Jul 2018 15:17:12 +0000 Received: from EX13MTAUWB001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-2b-c300ac87.us-west-2.amazon.com (8.14.7/8.14.7) with ESMTP id w6JFHA0W055027 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 19 Jul 2018 15:17:11 GMT Received: from EX13D08UWB004.ant.amazon.com (10.43.161.232) by EX13MTAUWB001.ant.amazon.com (10.43.161.207) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 19 Jul 2018 15:17:10 +0000 Received: from EX13D08UWB001.ant.amazon.com (10.43.161.104) by EX13D08UWB004.ant.amazon.com (10.43.161.232) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 19 Jul 2018 15:17:10 +0000 Received: from EX13D08UWB001.ant.amazon.com ([10.43.161.104]) by EX13D08UWB001.ant.amazon.com ([10.43.161.104]) with mapi id 15.00.1367.000; Thu, 19 Jul 2018 15:17:09 +0000 From: "R, Siva" To: Alexander Korotkov CC: pgsql-hackers Subject: Re: Bug in gin insert redo code path during re-compression of empty gin data leaf pages Thread-Topic: Bug in gin insert redo code path during re-compression of empty gin data leaf pages Thread-Index: AQHUHhriTtCi9KoAzkiIHCifB95wm6SUru8AgAHAO4CAABK9gIAAJso2 Date: Thu, 19 Jul 2018 15:17:09 +0000 Message-ID: <1532013429633.24570@amazon.com> References: <1531867212836.63354@amazon.com> , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.161.80] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Precedence: Bulk List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi Alexander!=0A= =0A= > On Thu, Jul 19, 2018 at 2:43 PM Alexander Korotkov wrote:=0A= > It appears that we need to handle empty posting list pages also in=A0dis= assembleLeaf().=A0 Updated patch is attached.=A0 I'm =0A= > going to commit it.=0A= Thank you so much for reviewing the patch! You are right, we need to handle= the regular insert/vacuum path for the empty page as well, thanks for fixi= ng that. The updated patch looks good to me.=0A= =0A= >BTW, what is your full name for the commit message? =0A= My full name is "Sivasubramanian Ramasubramanian". =0A= Email : sivasubr@amazon.com=0A= =0A= Thanks again!=0A= =0A= Best=0A= Siva=0A= =0A= =0A= =0A= =0A= =A0 =