Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fvTYN-00010G-My for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Aug 2018 20:28:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fvTYM-0002MX-0t for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Aug 2018 20:28:30 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fvTYL-0002MP-Mq for pgsql-hackers@lists.postgresql.org; Thu, 30 Aug 2018 20:28:29 +0000 Received: from gauss.credativ.com ([93.94.130.89]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fvTYH-0005D9-Er for pgsql-hackers@postgresql.org; Thu, 30 Aug 2018 20:28:28 +0000 Received: from gauss.credativ.com (localhost [127.0.0.1]) by gauss.credativ.com (Postfix) with ESMTP id B3C9D1E1A6E; Thu, 30 Aug 2018 22:28:22 +0200 (CEST) Received: from kohn.fritz.box (ppp-88-217-96-61.dynamic.mnet-online.de [88.217.96.61]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: mba@gauss.credativ.com) by gauss.credativ.com (Postfix) with ESMTPSA id 5E3571E199D; Thu, 30 Aug 2018 22:28:22 +0200 (CEST) Message-ID: <1535660901.1286.8.camel@credativ.de> Subject: Re: pg_verify_checksums and -fno-strict-aliasing From: Michael Banck To: Magnus Hagander , Tom Lane Cc: Fabien COELHO , pgsql-hackers Date: Thu, 30 Aug 2018 22:28:21 +0200 In-Reply-To: References: <1535618100.1286.3.camel@credativ.de> <7321.1535639966@sss.pgh.pa.us> Organization: credativ GmbH Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi, Am Donnerstag, den 30.08.2018, 21:35 +0200 schrieb Magnus Hagander: > So if I get you  right, you're saying the attached patch should be all > that's needed?  I tried to do some similar changes but neither what you proposed nor what I came up with actually fixes the checksum failures, though they silence the warning at -Wall level. Could well be I'm doing something wrong, so it would be cool if somebody could reproduce this first. In principle, it should be enough to run 'make clean && make CLFAGS=-O2' in the src/bin/pg_verify_checksums subdirectory in order to get a broken executable. Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.banck@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer Unser Umgang mit personenbezogenen Daten unterliegt folgenden Bestimmungen: https://www.credativ.de/datenschutz