Message-ID: <1546080943.3394.1.camel@credativ.de>
Subject: Re: Offline enabling/disabling of data checksums
From: Michael Banck <michael.banck@credativ.de>
To: Magnus Hagander <magnus@hagander.net>, Tomas Vondra
	 <tomas.vondra@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>, Postgres hackers
	 <pgsql-hackers@postgresql.org>
Date: Sat, 29 Dec 2018 11:55:43 +0100
In-Reply-To: 
 <CABUevEx_JyTWpSRkSf-Wyk+zuZqiOK=t5amqvD4bCQHyDjUfpQ@mail.gmail.com>
References: <20181221201616.GD4974@nighthawk.caipicrew.dd-dns.de>
	 <20181221232834.GB1948@paquier.xyz>
	 <CABUevEyUaB=Ws=DW-XsBw4ibDXZhQZ8d3WR4485bkmm13kTGVw@mail.gmail.com>
	 <348aef85-a967-80d2-7bef-7274909475cf@2ndquadrant.com>
	 <20181227232529.GA3210@paquier.xyz>
	 <bd6b833b-8250-0810-dfb6-4d8b3e6581b0@2ndquadrant.com>
	 <CABUevEx_JyTWpSRkSf-Wyk+zuZqiOK=t5amqvD4bCQHyDjUfpQ@mail.gmail.com>
Organization: credativ GmbH
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

Am Freitag, den 28.12.2018, 10:12 +0100 schrieb Magnus Hagander:
> On Fri, Dec 28, 2018 at 1:14 AM Tomas Vondra <tomas.vondra@2ndquadrant.com> wrote:
> > On 12/28/18 12:25 AM, Michael Paquier wrote:
> > > On Thu, Dec 27, 2018 at 03:46:48PM +0100, Tomas Vondra wrote:
> > >> On 12/27/18 11:43 AM, Magnus Hagander wrote:
> > >>> Should we double-check with packagers that this won't cause a problem?
> > >>> Though the fact that it's done in a major release should make it
> > >>> perfectly fine I think -- and it's a smaller change than when we did all
> > >>> those xlog->wal changes...
> > >>>
> > >>
> > >> I think it makes little sense to not rename the tool now. I'm pretty
> > >> sure we'd end up doing that sooner or later anyway, and we'll just live
> > >> with a misnamed tool until then.
> > > 
> > > Do you think that a thread Would on -packagers be more adapted then?
> > 
> > I'm sorry, but I'm not sure I understand the question. Of course, asking
> > over at -packagers won't hurt, but my guess is the response will be it's
> > not a big deal from the packaging perspective.
> 
> I think a heads- up in the way of "planning to change it, now's the
> time to yell" is the reasonable thing.

Renaming applications shouldn't be a problem unless they have to be
moved from one binary package to another. I assume all packagers ship
all client/server binaries in one package, respectively (and not e.g. a
dedicated postgresql-11-pg_test_fsync package), this should only be a
matter of updating package metadata.

In any case, it should be identical to the xlog->wal rename.


Michael

-- 
Michael Banck
Projektleiter / Senior Berater
Tel.: +49 2166 9901-171
Fax:  +49 2166 9901-100
Email: michael.banck@credativ.de

credativ GmbH, HRB Mönchengladbach 12080
USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer

Unser Umgang mit personenbezogenen Daten unterliegt
folgenden Bestimmungen: https://www.credativ.de/datenschutz