Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnNfn-0001qu-MZ for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Apr 2023 17:57:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pnNfm-0008Nf-I6 for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Apr 2023 17:57:22 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnNfm-0008NV-8a for pgsql-hackers@lists.postgresql.org; Fri, 14 Apr 2023 17:57:22 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnNfk-0003MJ-6z for pgsql-hackers@lists.postgresql.org; Fri, 14 Apr 2023 17:57:21 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 33EHvFjk1546513; Fri, 14 Apr 2023 13:57:15 -0400 From: Tom Lane To: Dag Lem cc: Andrew Dunstan , Tomas Vondra , Andres Freund , Alvaro Herrera , Paul Ramsey , PostgreSQL Hackers Subject: Re: daitch_mokotoff module In-reply-to: <9a774d09-bded-5039-0eec-2515c72215e4@dunslane.net> References: <20230208090954.ngbokgukzx7ooj3m@alvherre.pgsql> <53185f47-ed08-12ef-83d1-0cd26d49a209@enterprisedb.com> <20230211025830.twigy3l65bc27cyw@awork3.anarazel.de> <037c6b65-019e-7e4b-4fd0-77973ea75a9f@enterprisedb.com> <3135273.1680893728@sss.pgh.pa.us> <3271512.1680916423@sss.pgh.pa.us> <3278776.1680918752@sss.pgh.pa.us> <3287943.1680922997@sss.pgh.pa.us> <3298809.1680924332@sss.pgh.pa.us> <9a774d09-bded-5039-0eec-2515c72215e4@dunslane.net> Comments: In-reply-to Andrew Dunstan message dated "Sat, 08 Apr 2023 07:50:00 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <1546511.1681495035.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 14 Apr 2023 13:57:15 -0400 Message-ID: <1546512.1681495035@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Buildfarm member hamerkop has a niggle about this patch: c:\\build-farm-local\\buildroot\\head\\pgsql.build\\contrib\\fuzzystrmatch= \\daitch_mokotoff.c : warning C4819: The file contains a character that ca= nnot be represented in the current code page (932). Save the file in Unico= de format to prevent data loss It's complaining about the comment in static const char iso8859_1_to_ascii_upper[] =3D /* "`abcdefghijklmnopqrstuvwxyz{|}~ =C2=A1=C2= =A2=C2=A3=C2=A4=C2=A5=C2=A6=C2=A7=C2=A8=C2=A9=C2=AA=C2=AB=C2=AC =C2=AE=C2=AF= =C2=B0=C2=B1=C2=B2=C2=B3=C2=B4=C2=B5=C2=B6=C2=B7=C2=B8=C2=B9=C2=BA=C2=BB=C2= =BC=C2=BD=C2=BE=C2=BF=C3=80=C3=81=C3=82=C3=83=C3=84=C3=85=C3=86=C3=87=C3=88= =C3=89=C3=8A=C3=8B=C3=8C=C3=8D=C3=8E=C3=8F=C3=90=C3=91=C3=92=C3=93=C3=94=C3= =95=C3=96=C3=97=C3=98=C3=99=C3=9A=C3=9B=C3=9C=C3=9D=C3=9E=C3=9F=C3=A0=C3=A1= =C3=A2=C3=A3=C3=A4=C3=A5=C3=A6=C3=A7=C3=A8=C3=A9=C3=AA=C3=AB=C3=AC=C3=AD=C3= =AE=C3=AF=C3=B0=C3=B1=C3=B2=C3=B3=C3=B4=C3=B5=C3=B6=C3=B7=C3=B8=C3=B9=C3=BA= =C3=BB=C3=BC=C3=BD=C3=BE=C3=BF" */ "`ABCDEFGHIJKLMNOPQRSTUVWXYZ{|}~ ! = ?AAAAAAECEEEEIIIIDNOOOOO*OUUUUYDSAAAAAAECEEEEIIIIDNO= OOOO/OUUUUYDY"; There are some other comments with non-ASCII characters elsewhere in the file, but I think it's mainly just the weird symbols here that might fail to translate to encodings that are not based on ISO 8859-1. I think we need to get rid of this warning: it's far from obvious that it's a non-issue, and because the compiler is not at all specific about where the issue is, people could waste a lot of time figuring that out. In fact, it might *not* be a non-issue, if it prevents the source tree as a whole from being processed by some tool or other. So I propose to replace those symbols with "... random symbols ..." or the like and see if the warning goes away. If not, we might have to resort to something more drastic like removing this comment altogether. We do have non-ASCII text in comments and test cases elsewhere in the tree, and have not had a lot of trouble with that, so I'm hoping the letters can stay because they are useful to compare to the constant. regards, tom lane