Subject: Re: compute_query_id and pg_stat_statements
To: Michael Paquier <michael@paquier.xyz>, Julien Rouhaud <rjuju123@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>, Stephen Frost
 <sfrost@snowman.net>, Magnus Hagander <magnus@hagander.net>,
 Bruce Momjian <bruce@momjian.us>, Christoph Berg <myon@debian.org>,
 Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
References: <2268611.1619458140@sss.pgh.pa.us>
 <20210426174331.GA19401@alvherre.pgsql>
 <20210426181408.3j6kkzpxnadpwptv@alap3.anarazel.de>
 <2295572.1619461260@sss.pgh.pa.us>
 <20210426183745.4gd2s5qra6mlxfto@alap3.anarazel.de>
 <20210427062504.ofz3rgedbrl5bep2@nol> <YJoeXcrwe1EDmqKT@paquier.xyz>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <154cacc0-9aa9-a37b-0a0f-17aa08ff706e@oss.nttdata.com>
Date: Tue, 11 May 2021 15:34:18 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <YJoeXcrwe1EDmqKT@paquier.xyz>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/154cacc0-9aa9-a37b-0a0f-17aa08ff706e%40oss.nttdata.com>
Precedence: bulk


On 2021/05/11 15:04, Michael Paquier wrote:
> On Tue, Apr 27, 2021 at 02:25:04PM +0800, Julien Rouhaud wrote:
>> On Mon, Apr 26, 2021 at 11:37:45AM -0700, Andres Freund wrote:
>>> On 2021-04-26 14:21:00 -0400, Tom Lane wrote:
>>>> That's sounding like a pretty sane design, actually.  Not sure about
>>>> the shared-library-name-with-fixed-function-name detail, but certainly
>>>> it seems to be useful to separate "I need a query-id" from the details
>>>> of the ID calculation.
>>>>
>>>> Rather than a GUC per se for the ID provider, maybe we could have a
>>>> function hook that defaults to pointing at the in-core computation,
>>>> and then a module wanting to override that just gets into the hook.
>>>
>>> I have a preference to determining the provider via GUC instead of a
>>> hook because it is both easier to introspect and easier to configure.
> 
> So, this thread has died two weeks ago, and it is still an open item.
> Could it be possible to move to a resolution by beta1?  The consensus
> I can get from the thread is that we should have a tri-value state to
> track an extra "auto" for the query ID computation, as proposed by
> Alvaro here:
> https://www.postgresql.org/message-id/20210426174331.GA19401@alvherre.pgsql

+1

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION