Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBjRV-00C7uk-FO for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Dec 2023 22:35:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rBjRU-00CNfi-4H for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Dec 2023 22:35:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBjRT-00CNfa-QR for pgsql-hackers@lists.postgresql.org; Fri, 08 Dec 2023 22:35:31 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBjRR-00AtFg-Am for pgsql-hackers@postgresql.org; Fri, 08 Dec 2023 22:35:31 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 3B8MZQ971551184; Fri, 8 Dec 2023 17:35:26 -0500 From: Tom Lane To: Andres Freund cc: Peter Eisentraut , pgsql-hackers Subject: Re: backtrace_on_internal_error In-reply-to: <20231208221554.f5fmjjqowktnmqlk@awork3.anarazel.de> References: <93f32d1a-9309-48dc-9b7f-c110c4d48126@eisentraut.org> <1266459.1701958930@sss.pgh.pa.us> <1439034.1702047909@sss.pgh.pa.us> <20231208181451.deqnflwxqoehhxpe@awork3.anarazel.de> <1466396.1702059830@sss.pgh.pa.us> <20231208183440.5z2rdpojcs5h5slk@awork3.anarazel.de> <1469753.1702061167@sss.pgh.pa.us> <20231208185101.x5z6vgkdtakqo4ny@awork3.anarazel.de> <20231208193316.5ylgs4zb6zngwyg4@awork3.anarazel.de> <20231208221554.f5fmjjqowktnmqlk@awork3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Fri, 08 Dec 2023 14:15:54 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1551182.1702074926.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 08 Dec 2023 17:35:26 -0500 Message-ID: <1551183.1702074926@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > I thought it'd be nice to have a test for this, particularly because it'= s not > clear that the behaviour is consistent across openssl versions. Perhaps, but ... > To deal with that, I changed the test to instead check if "not accept SS= L > connection: Success" is not logged. ... testing only that much seems entirely not worth the cycles, given the shape of the patches we both just made. If we can't rely on "errno !=3D 0= " to ensure we won't get "Success", there is one heck of a lot of other code that will be broken worse than this. regards, tom lane