Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sllJO-0011Ey-EY for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Sep 2024 08:24:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sllJN-006ANv-2N for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Sep 2024 08:24:21 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sllJM-006ANn-MP for pgsql-hackers@lists.postgresql.org; Wed, 04 Sep 2024 08:24:21 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sllJJ-00054d-Kt for pgsql-hackers@lists.postgresql.org; Wed, 04 Sep 2024 08:24:19 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 053109A82B for ; Wed, 04 Sep 2024 10:23:56 +0200 (CEST) Received: from s899.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id DFB899A06E; Wed, 04 Sep 2024 10:23:55 +0200 (CEST) Received: from s470.loopia.se (unknown [172.22.191.5]) by s899.loopia.se (Postfix) with ESMTP id DBFDD2C8BA83; Wed, 04 Sep 2024 10:23:55 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s470.loopia.se (amavisd-new); dkim=pass (2048-bit key) header.d=yesql.se Received: from s979.loopia.se ([172.22.191.5]) by s470.loopia.se (s470.loopia.se [172.22.190.34]) (amavisd-new, port 10024) with LMTP id H-rGe9qHLRRt; Wed, 4 Sep 2024 10:23:55 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s979.loopia.se (Postfix) with ESMTPSA id 5049510BC40D; Wed, 04 Sep 2024 10:23:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yesql.se; s=loopiadkim1707475645; t=1725438235; bh=TxTDmsjx7/dbHWRFJ4G5inwwG5Nw0p5twoiUPrBFEik=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=q8z9IvKit+/0rU1YDUXkbOFcNlwur3JGWHkkDDjhfOEk4mf58eSuO1VO8Wxwa7PRK rjfmUg9of2flruzS+bWym6fGjDozX1v2j/DjhyyKmb0kYcjn7qWx/SXeyS0L+0XQ7s p9fWmBIxgHSmCPZm5tRK2uz5iHrE+Zr8EWlO2XJowHRnwLdaiNLfG92hl90z7O+03h lUmq6up/d/J0dB/+DipZyFW3xX0UYqi4qy6dl4iM8ViX8GHSr2l1dLpLxbaPjcK8mA 2vorcGorS068NIo4HvSuoWnc7cvOkIN0wfFomd05/MfDTin0GvG27riH4tpp2YSx9L PEJm9T7o09KZw== Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Subject: Re: Typos in the code and README From: Daniel Gustafsson In-Reply-To: Date: Wed, 4 Sep 2024 10:23:44 +0200 Cc: Alexander Lakhin , David Rowley , Tom Lane , Robert Haas , Nazir Bilal Yavuz , Heikki Linnakangas , PostgreSQL Developers Content-Transfer-Encoding: quoted-printable Message-Id: <15512E98-BDB0-44E3-AAB6-217F322AB5F0@yesql.se> References: To: Michael Paquier X-Mailer: Apple Mail (2.3774.600.62) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 4 Sep 2024, at 03:25, Michael Paquier wrote: >=20 > On Tue, Sep 03, 2024 at 12:00:13PM +0200, Daniel Gustafsson wrote: >> I see your v17 typo fixes, and raise you a few more. Commit = 31a98934d169 from >> just now contains 2 (out of 3) sets of typos introduced in v17 so = they should >> follow along when you push the ones mentioned here. >=20 > Is that really mandatory? I tend to worry about back branches only > when this stuff is user-visible, like in the docs or error messages. > This opinion varies for each individual, of course. That's just my > lazy opinion. Not mandatory at all, but since you were prepping a typo backpatch = anyways I figured these could join to put a small dent in reducing risks for = future backports. -- Daniel Gustafsson