Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h3I2E-0005RJ-Qf for pgsql-hackers@arkaria.postgresql.org; Mon, 11 Mar 2019 10:19:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h3I2D-0001Yy-9P for pgsql-hackers@arkaria.postgresql.org; Mon, 11 Mar 2019 10:19:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h3I2D-0001Yq-1p for pgsql-hackers@lists.postgresql.org; Mon, 11 Mar 2019 10:19:53 +0000 Received: from gauss.credativ.com ([93.94.130.89]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h3I2B-00008B-K5 for pgsql-hackers@postgresql.org; Mon, 11 Mar 2019 10:19:52 +0000 Received: from gauss.credativ.com (localhost [127.0.0.1]) by gauss.credativ.com (Postfix) with ESMTP id 201FD1E3BBF; Mon, 11 Mar 2019 11:19:51 +0100 (CET) Received: from kohn (fw-front.credativ.com [62.154.226.94]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: mba@gauss.credativ.com) by gauss.credativ.com (Postfix) with ESMTPSA id CD3DF1E39F5; Mon, 11 Mar 2019 11:19:50 +0100 (CET) Message-ID: <1552299590.4947.48.camel@credativ.de> Subject: Re: Offline enabling/disabling of data checksums From: Michael Banck To: Michael Paquier , Fabien COELHO Cc: Postgres hackers Date: Mon, 11 Mar 2019 11:19:50 +0100 In-Reply-To: <1552299104.4947.46.camel@credativ.de> References: <20181221201616.GD4974@nighthawk.caipicrew.dd-dns.de> <1546949005.32387.11.camel@credativ.de> <1550428298.12689.12.camel@credativ.de> <20190219050224.GV15532@paquier.xyz> <1551195322.4947.16.camel@credativ.de> <20190311045323.GE1818@paquier.xyz> <1552299104.4947.46.camel@credativ.de> Organization: credativ GmbH Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi, Am Montag, den 11.03.2019, 11:11 +0100 schrieb Michael Banck: > I had a quick look over the patch and your changes and it LGTM. One thing: you (Michael) should be co-author for patch #3 as I took some of your code from https://github.com/michaelpq/pg_plugins/tree/master/pg _checksums Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.banck@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer Unser Umgang mit personenbezogenen Daten unterliegt folgenden Bestimmungen: https://www.credativ.de/datenschutz