Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h3ePy-0000hA-VV for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Mar 2019 10:13:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h3ePx-0007rf-Kq for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Mar 2019 10:13:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h3ePx-0007rX-AW for pgsql-hackers@lists.postgresql.org; Tue, 12 Mar 2019 10:13:53 +0000 Received: from gauss.credativ.com ([93.94.130.89]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h3ePu-0005bK-CI for pgsql-hackers@lists.postgresql.org; Tue, 12 Mar 2019 10:13:52 +0000 Received: from gauss.credativ.com (localhost [127.0.0.1]) by gauss.credativ.com (Postfix) with ESMTP id 4D3871E36AE; Tue, 12 Mar 2019 11:13:47 +0100 (CET) Received: from kohn (fw-front.credativ.com [62.154.226.94]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: mba@gauss.credativ.com) by gauss.credativ.com (Postfix) with ESMTPSA id 0787C1E23E8; Tue, 12 Mar 2019 11:13:46 +0100 (CET) Message-ID: <1552385626.4947.50.camel@credativ.de> Subject: Re: Offline enabling/disabling of data checksums From: Michael Banck To: Sergei Kornilov , pgsql-hackers@lists.postgresql.org Date: Tue, 12 Mar 2019 11:13:46 +0100 In-Reply-To: <155231347133.16480.11453587097036807558.pgcf@coridan.postgresql.org> References: <20181221201616.GD4974@nighthawk.caipicrew.dd-dns.de> <20190311045323.GE1818@paquier.xyz> <155231347133.16480.11453587097036807558.pgcf@coridan.postgresql.org> Organization: credativ GmbH Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi, Am Montag, den 11.03.2019, 14:11 +0000 schrieb Sergei Kornilov: > > if (badblocks > 0) > > return 1; > > Small question: why return 1 instead of exit(1)? I have a feeling it is project policy to return 0 from main(), and exit(1) if a program aborts with an error. In the above case, the program finishes more-or-less as intended (no abort), but due to errors found on the way, does not return with 0. I don't mind either way and probably exit(1) makes more sense, but I wanted to explain why it is like that. Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.banck@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer Unser Umgang mit personenbezogenen Daten unterliegt folgenden Bestimmungen: https://www.credativ.de/datenschutz