Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h424h-0000ve-62 for pgsql-hackers@arkaria.postgresql.org; Wed, 13 Mar 2019 11:29:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h424f-0002uD-Vs for pgsql-hackers@arkaria.postgresql.org; Wed, 13 Mar 2019 11:29:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h424f-0002qq-Ky for pgsql-hackers@lists.postgresql.org; Wed, 13 Mar 2019 11:29:29 +0000 Received: from gauss.credativ.com ([93.94.130.89]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h424a-0006Ev-6G for pgsql-hackers@lists.postgresql.org; Wed, 13 Mar 2019 11:29:28 +0000 Received: from gauss.credativ.com (localhost [127.0.0.1]) by gauss.credativ.com (Postfix) with ESMTP id 658471E39F7; Wed, 13 Mar 2019 12:29:22 +0100 (CET) Received: from kohn (fw-front.credativ.com [62.154.226.94]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: mba@gauss.credativ.com) by gauss.credativ.com (Postfix) with ESMTPSA id 04BCB1E1BC7; Wed, 13 Mar 2019 12:29:21 +0100 (CET) Message-ID: <1552476561.4947.67.camel@credativ.de> Subject: Re: Offline enabling/disabling of data checksums From: Michael Banck To: Magnus Hagander , Sergei Kornilov Cc: Michael Paquier , Fabien COELHO , PostgreSQL Developers Date: Wed, 13 Mar 2019 12:29:21 +0100 In-Reply-To: References: <20181221201616.GD4974@nighthawk.caipicrew.dd-dns.de> <20190311045323.GE1818@paquier.xyz> <155231347133.16480.11453587097036807558.pgcf@coridan.postgresql.org> <1552385626.4947.50.camel@credativ.de> <20190312124403.GM13812@paquier.xyz> <20190313021621.GP13812@paquier.xyz> <20190313093150.GE2988@paquier.xyz> <20190313101021.GF2988@paquier.xyz> <5217311552474471@myt2-66bcb87429e6.qloud-c.yandex.net> Organization: credativ GmbH Content-Type: multipart/mixed; boundary="=-PM31QVHGocQjCsdrU6zd" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --=-PM31QVHGocQjCsdrU6zd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hi, Am Mittwoch, den 13.03.2019, 12:24 +0100 schrieb Magnus Hagander: > > Also we support ./configure --with-blocksize=(not equals 8)? make > > check on HEAD fails for me. If we support this - i think we need > > recheck BLCKSZ between compiled pg_checksum and used in PGDATA > > You mean if the backend and pg_checksums is built with different > blocksize? Yeah, that sounds like something which is a cheap check and > should be done.  I've been doing that in my pg_checksums fork for a while (as it further removed from the Postgres binaries) but yeah we should check for that as well in pg_checksums, see attached patch. Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.banck@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer Unser Umgang mit personenbezogenen Daten unterliegt folgenden Bestimmungen: https://www.credativ.de/datenschutz --=-PM31QVHGocQjCsdrU6zd Content-Disposition: attachment; filename="0001-Check-data-directory-block-size.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-Check-data-directory-block-size.patch"; charset="UTF-8" RnJvbSBmOTQyMTM2ZTA5Y2Q1NGIxMDMyYzdjNWQ5YjRmMzMwNWU3ZGMwNDNmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIEJhbmNrIDxtYmFuY2tAZGViaWFuLm9yZz4KRGF0 ZTogV2VkLCAxMyBNYXIgMjAxOSAxMjoyNzo0NCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIENoZWNr IGRhdGEgZGlyZWN0b3J5IGJsb2NrIHNpemUKCi0tLQogc3JjL2Jpbi9wZ19jaGVja3N1bXMvcGdf Y2hlY2tzdW1zLmMgfCAxMSArKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlv bnMoKykKCmRpZmYgLS1naXQgYS9zcmMvYmluL3BnX2NoZWNrc3Vtcy9wZ19jaGVja3N1bXMuYyBi L3NyYy9iaW4vcGdfY2hlY2tzdW1zL3BnX2NoZWNrc3Vtcy5jCmluZGV4IGFmY2E2Y2YwMjcuLmRm ZDUyMmNhNmEgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vcGdfY2hlY2tzdW1zL3BnX2NoZWNrc3Vtcy5j CisrKyBiL3NyYy9iaW4vcGdfY2hlY2tzdW1zL3BnX2NoZWNrc3Vtcy5jCkBAIC00NDIsNiArNDQy LDE3IEBAIG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAkJZXhpdCgxKTsKIAl9CiAKKwkv KgorCSAqIENoZWNrIHRoYXQgdGhlIFBHREFUQSBibG9ja3NpemUgaXMgdGhlIHNhbWUgYXMgdGhl IG9uZSBwZ19jaGVja3N1bXMKKwkgKiB3YXMgY29tcGlsZWQgYWdhaW5zdCAoQkxDS1NaKS4KKwkg Ki8KKwlpZiAoQ29udHJvbEZpbGUtPmJsY2tzeiAhPSBCTENLU1opCisJeworCQlmcHJpbnRmKHN0 ZGVyciwgXygiJXM6IGRhdGEgZGlyZWN0b3J5IGJsb2NrIHNpemUgJWQgaXMgZGlmZmVyZW50IHRv IGNvbXBpbGVkLWluIGJsb2NrIHNpemUgJWQuXG4iKSwKKwkJCQlwcm9nbmFtZSwgQ29udHJvbEZp bGUtPmJsY2tzeiwgQkxDS1NaKTsKKwkJZXhpdCgxKTsKKwl9CisKIAkvKiBTYXZlIHRpbWUgb2Yg bGFzdCBjb250cm9sIGZpbGUgbW9kaWZpY2F0aW9uICovCiAJY29udHJvbGZpbGVfbGFzdF91cGRh dGVkID0gQ29udHJvbEZpbGUtPnRpbWU7CiAKLS0gCjIuMTEuMAoK --=-PM31QVHGocQjCsdrU6zd--