Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h6hSa-0007zT-F9 for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Mar 2019 20:05:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h6hSZ-0000QP-1K for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Mar 2019 20:05:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h6hSY-0000QI-Mc for pgsql-hackers@lists.postgresql.org; Wed, 20 Mar 2019 20:05:10 +0000 Received: from n3.nabble.com ([162.255.23.22]) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h6hSV-00077H-DY for pgsql-hackers@postgresql.org; Wed, 20 Mar 2019 20:05:09 +0000 Received: from n3.nabble.com (localhost [127.0.0.1]) by n3.nabble.com (Postfix) with ESMTP id 8616812B73566 for ; Wed, 20 Mar 2019 13:05:06 -0700 (MST) Date: Wed, 20 Mar 2019 13:05:06 -0700 (MST) From: legrand legrand To: pgsql-hackers@postgresql.org Message-ID: <1553112306545-0.post@n3.nabble.com> In-Reply-To: <20190320.104446.68838245.horiguchi.kyotaro@lab.ntt.co.jp> References: <1553029215728-0.post@n3.nabble.com> <0A3221C70F24FB45833433255569204D1FBE20A4@G01JPEXMBYT05> <20190320.104446.68838245.horiguchi.kyotaro@lab.ntt.co.jp> Subject: Re: [survey] New "Stable" QueryId based on normalized query text MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk > From "Kyotaro HORIGUCHI-2" >>At Wed, 20 Mar 2019 00:23:30 +0000, "Tsunakawa, Takayuki" >>> From: legrand legrand [mailto:legrand_legrand@] >>> norm.9: comments aware >> Is this to distinguish queries that have different comments for optimizer >> hints? If yes, I agree. > Or, any means to give an explict query id? I saw many instances > of query that follows a comment describing a query id. Yes, in fact didn't thought about different kink of comments, but all of them >> needs.3: search_path / schema independant, >pg_stat_statements even ignores table/object/column names. there is a very interesting thread about that in "pg_stat_statements and non default search_path" https://www.postgresql.org/message-id/8f54c609-17c6-945b-fe13-8b07c0866420@dalibo.com expecting distinct QueryIds when using distinct schemas ... maybe that It should be switched to "Schema dependant" >> needs.4: pg version independant (as long as possible), >I don't think this cannot be guaranteed. maybe using a QueryId versioning GUC >> norm.1: case insensitive >> norm.2: blank reduction >> norm.3: hash algoritm ? >> norm.4: CURRENT_DATE, CURRENT_TIME, LOCALTIME, LOCALTIMESTAMP not >> normalized >> norm.5: NULL, IS NULL not normalized ? >> norm.6: booleans t, f, true, false not normalized >> norm.7: order by 1,2 or group by 1,2 should not be normalized >> norm.8: pl/pgsql anonymous blocks not normalized > pg_stat_statements can be the base of the discussion on them. OK Regards PAscal -- Sent from: http://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html