Date: Wed, 20 Mar 2019 15:19:58 -0700 (MST)
From: legrand legrand <legrand_legrand@hotmail.com>
To: pgsql-hackers@postgresql.org
Message-ID: <1553120398016-0.post@n3.nabble.com>
In-Reply-To: 
 <CAOBaU_atk6WMxA=ajNURThwmJ2jMyEfkE88TSkwtOfvk4gXrFA@mail.gmail.com>
References: <1553029215728-0.post@n3.nabble.com>
 <0A3221C70F24FB45833433255569204D1FBE20A4@G01JPEXMBYT05>
 <1553110765067-0.post@n3.nabble.com>
 <CAOBaU_ZJShkK40_suw9NtUZEtoM07PYg4c_G2m_=HyXQ+pzoAw@mail.gmail.com>
 <1553116679891-0.post@n3.nabble.com> <1553117433667-0.post@n3.nabble.com>
 <CAOBaU_atk6WMxA=ajNURThwmJ2jMyEfkE88TSkwtOfvk4gXrFA@mail.gmail.com>
Subject: Re: [survey] New "Stable" QueryId based on normalized query text
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk

Julien Rouhaud wrote
> On Wed, Mar 20, 2019 at 10:30 PM legrand legrand
> &lt;

> legrand_legrand@

> &gt; wrote:
>>
>> maybe this patch (with a GUC)
>> https://www.postgresql.org/message-id/

> 55E51C48.1060102@

>> would be enough for thoses actually using a text normalization function.
> 
> The rest of thread raise quite a lot of concerns about the semantics,
> the cost and the correctness of this patch.  After 5 minutes checking,
> it wouldn't suits your need if you use custom functions, custom types,
> custom operators (say using intarray extension) or if your tables
> don't have columns in the same order in every environment.  And there
> are probably other caveats that I didn't see;

Yes I know,
It would have to be extended at less at functions, types, operators ...
names
and a guc pg_stat_statements.queryid_based= 'names' (default being 'oids')

and with a second guc ('fullyqualifed' ?)
sould include tables, functions, types, operators ... namespaces

let "users" specify their needs, we will see ;o)


--
Sent from: http://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html