From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
        Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>,
        Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        "Joshua D. Drake" <jd@commandprompt.com>,
        Thomas Munro <thomas.munro@enterprisedb.com>,
        David Steele <david@pgmasters.net>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Craig Ringer <craig@2ndquadrant.com>
Subject: Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c)
In-reply-to: <20180824154623.i32aryx4bzfa4gxu@alap3.anarazel.de>
References: <1d5946a3-aa85-a3ec-c8aa-b3e9b66dd5d9@commandprompt.com>
 <20180821204936.tqdmjolkoo2sv5og@alap3.anarazel.de>
 <303572b3-89a5-6177-d46a-e23b2b4d6caa@2ndQuadrant.com>
 <20180821232952.ixj6kgccoqcjp5gf@alap3.anarazel.de>
 <CANFyU94+wn2iN_ry=2SZFzxdFP6vAHA2+K0uhyyCS4YQWyyrxw@mail.gmail.com>
 <20180822120211.prl6uxspai4lahfs@alap3.anarazel.de>
 <20180823000905.fjthfohmczss4fiw@alap3.anarazel.de>
 <20180823013134.3h4j62eeiaibpgvo@alap3.anarazel.de>
 <eedbe1a9-1d3f-e878-7695-fe9b529f3239@2ndquadrant.com>
 <20180824014434.qourppnik7bmsib6@alap3.anarazel.de>
 <20180824154623.i32aryx4bzfa4gxu@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Fri, 24 Aug 2018 08:46:23 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <15586.1535127034.1@sss.pgh.pa.us>
Date: Fri, 24 Aug 2018 12:10:34 -0400
Message-ID: <15587.1535127034@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> I'd like to change it so it doesn't enforce C89 compliance across the
> board, but instead enforces the relevant standard. For that I'd need to
> change CFLAGS per-branch in the buildfarm. Is that possible already? Do
> I need two different config files?

I just did that on dromedary, with a stanza like this at the bottom:

if ($branch eq 'HEAD' or $branch ge 'REL_12')
{
        $conf{config_env}->{CC} = 'ccache gcc -std=c99';
}
else
{
        $conf{config_env}->{CC} = 'ccache gcc -ansi';
}

			regards, tom lane