pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
Typo in multixact.c and jsonfuncs.c documentation
4+ messages / 3 participants
[nested] [flat]

Commits from this thread:
  2025-04-30 918e7287ed  Fix broken indentation
  2025-04-30 d8555e522e  Fix a couple of comment typos
* Typo in multixact.c and jsonfuncs.c documentation
@ 2025-04-30 01:24  Junwang Zhao <zhjwpku@gmail.com>
  0 siblings, 1 reply; 4+ messages in thread

From: Junwang Zhao @ 2025-04-30 01:24 UTC (permalink / raw)
  To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Found a trivial typo in multixact.c, after searching the code base
there is another such typo in jsonfuncs.c.

- * range, that is, greater to or equal than oldestMultiXactId, and less than
+ * range, that is, greater than or equal to oldestMultiXactId, and less than

-- 
Regards
Junwang Zhao

Attachments:

v1-0001-Fix-typo-in-multixact.c-and-jsonfuncs.c-documenta.patch (application/octet-stream, 1.7K) download From e72ac5299bdcfadcfcde20c27e2d86c97b73e638 Mon Sep 17 00:00:00 2001 From: Junwang Zhao <zhjwpku@gmail.com> Date: Wed, 30 Apr 2025 01:20:17 +0000 Subject: [PATCH v1] Fix typo in multixact.c and jsonfuncs.c documentation --- src/backend/access/transam/multixact.c | 2 +- src/backend/utils/adt/jsonfuncs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/access/transam/multixact.c b/src/backend/access/transam/multixact.c index 9d25a7df0d3..ef91e70f41d 100644 --- a/src/backend/access/transam/multixact.c +++ b/src/backend/access/transam/multixact.c @@ -1287,7 +1287,7 @@ GetNewMultiXactId(int nmembers, MultiXactOffset *offset) * range, in which case an error would be raised. * * In all other cases, the passed multixact must be within the known valid - * range, that is, greater to or equal than oldestMultiXactId, and less than + * range, that is, greater than or equal to oldestMultiXactId, and less than * nextMXact. Otherwise, an error is raised. * * isLockOnly must be set to true if caller is certain that the given multi diff --git a/src/backend/utils/adt/jsonfuncs.c b/src/backend/utils/adt/jsonfuncs.c index 9f43b58dba5..eab102a2474 100644 --- a/src/backend/utils/adt/jsonfuncs.c +++ b/src/backend/utils/adt/jsonfuncs.c @@ -1723,7 +1723,7 @@ push_path(JsonbParseState **st, int level, Datum *path_elems, { /* * tpath contains expected type of an empty jsonb created at each level - * higher or equal than the current one, either jbvObject or jbvArray. + * higher or equal to the current one, either jbvObject or jbvArray. * Since it contains only information about path slice from level to the * end, the access index must be normalized by level. */ -- 2.39.5
^ permalink raw reply [nested|flat] 4+ messages in thread

* Re: Typo in multixact.c and jsonfuncs.c documentation
@ 2025-04-30 01:41  David Rowley <dgrowleyml@gmail.com>
  parent: Junwang Zhao <zhjwpku@gmail.com>
  0 siblings, 1 reply; 4+ messages in thread

From: David Rowley @ 2025-04-30 01:41 UTC (permalink / raw)
  To: Junwang Zhao <zhjwpku@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

On Wed, 30 Apr 2025 at 13:25, Junwang Zhao <zhjwpku@gmail.com> wrote:
> Found a trivial typo in multixact.c, after searching the code base
> there is another such typo in jsonfuncs.c.

Thanks. Pushed.

David





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: Typo in multixact.c and jsonfuncs.c documentation
@ 2025-04-30 07:13  Fujii Masao <masao.fujii@oss.nttdata.com>
  parent: David Rowley <dgrowleyml@gmail.com>
  0 siblings, 1 reply; 4+ messages in thread

From: Fujii Masao @ 2025-04-30 07:13 UTC (permalink / raw)
  To: David Rowley <dgrowleyml@gmail.com>; Junwang Zhao <zhjwpku@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>



On 2025/04/30 10:41, David Rowley wrote:
> On Wed, 30 Apr 2025 at 13:25, Junwang Zhao <zhjwpku@gmail.com> wrote:
>> Found a trivial typo in multixact.c, after searching the code base
>> there is another such typo in jsonfuncs.c.
> 
> Thanks. Pushed.

This commit seems to have caused an indent-check failure on the buildfarm member koel.
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2025-04-30%2002%3A19%3A00

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION






^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: Typo in multixact.c and jsonfuncs.c documentation
@ 2025-04-30 07:29  David Rowley <dgrowleyml@gmail.com>
  parent: Fujii Masao <masao.fujii@oss.nttdata.com>
  0 siblings, 0 replies; 4+ messages in thread

From: David Rowley @ 2025-04-30 07:29 UTC (permalink / raw)
  To: Fujii Masao <masao.fujii@oss.nttdata.com>; +Cc: Junwang Zhao <zhjwpku@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

On Wed, 30 Apr 2025 at 19:13, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> This commit seems to have caused an indent-check failure on the buildfarm member koel.
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2025-04-30%2002%3A19%3A00

Thanks. Fixed.

David





^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2025-04-30 07:29 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-04-30 01:24 Typo in multixact.c and jsonfuncs.c documentation Junwang Zhao <zhjwpku@gmail.com>
2025-04-30 01:41 ` David Rowley <dgrowleyml@gmail.com>
2025-04-30 07:13   ` Fujii Masao <masao.fujii@oss.nttdata.com>
2025-04-30 07:29     ` David Rowley <dgrowleyml@gmail.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox