From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Annoying build warnings from latest Apple toolchain
In-reply-to: <20230930171306.z2qnufu35omjhs62@alap3.anarazel.de>
References: <467042.1695766998@sss.pgh.pa.us>
 <673900.1695841549@sss.pgh.pa.us> <687188.1695847964@sss.pgh.pa.us>
 <20230928203213.47bn2pv45mkmxtz7@alap3.anarazel.de>
 <1095659.1695933968@sss.pgh.pa.us>
 <20230928222248.jw6s7yktpfsfczha@alap3.anarazel.de>
 <1111721.1695941929@sss.pgh.pa.us> <1289531.1696004080@sss.pgh.pa.us>
 <20230930171306.z2qnufu35omjhs62@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sat, 30 Sep 2023 10:13:06 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1562622.1696094881.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 30 Sep 2023 13:28:01 -0400
Message-ID: <1562623.1696094881@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1562623.1696094881%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2023-09-29 12:14:40 -0400, Tom Lane wrote:
>> Looking closer, it's only since v16 that we have export list support
>> on all officially-supported platforms.

> Oh, right, before that Solaris didn't support it. I guess we could backp=
atch
> that commit, it's simple enough, but I don't think I care enough about S=
olaris
> to do so.

HPUX would be an issue too, as we never did figure out how to do
export control on that.  However, I doubt it would be a great idea
to back-patch export control in minor releases, even if we had
the patch at hand.  That would be an ABI break of its own, although
it'd only affect clients that hadn't done things quite correctly.

>> Therefore, I think the prudent thing to do in the back branches is use =
the
>> patch I posted before, to suppress the duplicate -l switches only on ma=
cOS.
>> In HEAD, I propose we simplify life by doing it everywhere, as attached=
.

> Makes sense.

Done that way.  Were you going to push the -Wl,-exported_symbols_list
change?

			regards, tom lane