Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvfe9-0003xK-B5 for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Dec 2021 13:09:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mvfe6-000160-HS for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Dec 2021 13:09:06 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvfe5-00015r-9b for pgsql-hackers@lists.postgresql.org; Fri, 10 Dec 2021 13:09:06 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvfdw-0004Gy-Qd for pgsql-hackers@postgresql.org; Fri, 10 Dec 2021 13:09:03 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id F051A5C0186; Fri, 10 Dec 2021 08:08:54 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 10 Dec 2021 08:08:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=8YE7Ax XlIvRfF2q0WhnnIqgbgXe0eK1BSfx59Sdbvk4=; b=OjYiZOk5hMrIpxxN00SCt1 h2kluPmnZDSOHrfhEGg1gfvHpZywZgK7bjeI6ZEXQOOe4gkhSrZvSycMkkEibBnw NjXqOcmNjd81eIRoVFfAv7d8NnvTdCXn2sujKHRe5yMiefkZ3aJStpMO9KnhMAoK wjqozSvhpU1ixmWnLziC5oZvlPxZ+p8CPW+aWinYZiX/7EFDPFw7yvUayPQ+Kq4x IbM+XOt2av6LpeSVMP++3/4Zfp/OjJXwxLMwuCvp2NXti12DswBjqlicUwAWb7/6 Fychn9kRLSqslRWdYv9LtLBJ3tMdKUYR9rPhracxFI2+sWKLC4yoH8xF3s75lprw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrkedvgdeglecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfuffvfhfhjgesmhdtreertdefjeenucfhrhhomheprfgvthgvrhcu gfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsegvnhhtvghrph hrihhsvggusgdrtghomheqnecuggftrfgrthhtvghrnhepuddtveeltdevvdetuddvfedv hfeiteekledvhffhjeefjedvueejgeegfedugedtnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgruhhtsegv nhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 10 Dec 2021 08:08:53 -0500 (EST) Content-Type: multipart/mixed; boundary="------------l5L0oS80CIgiENkK7lOqL2CH" Message-ID: <15691075-5172-ad49-e7ae-89b82c1f0cfc@enterprisedb.com> Date: Fri, 10 Dec 2021 14:08:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: Column Filtering in Logical Replication Content-Language: en-US To: Alvaro Herrera Cc: PostgreSQL-development References: <202112021423.cxdhpzub7mfe@alvherre.pgsql> From: Peter Eisentraut In-Reply-To: <202112021423.cxdhpzub7mfe@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------l5L0oS80CIgiENkK7lOqL2CH Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02.12.21 15:23, Alvaro Herrera wrote: >> I took the latest posted patch, rebased on current sources, fixed the >> conflicts, and pgindented. No further changes. Here's the result. All >> tests are passing for me. Some review comments that were posted have >> not been addressed yet; I'll look into that soon. > > In v7 I have reinstated the test file and fixed the silly problem that > caused it to fail (probably a mistake of mine while rebasing). I looked through this a bit. You had said that you are still going to integrate past review comments, so I didn't look to deeply before you get to that. Attached are a few fixup patches that you could integrate. There was no documentation, so I wrote a bit (patch 0001). It only touches the CREATE PUBLICATION and ALTER PUBLICATION pages at the moment. There was no mention in the Logical Replication chapter that warranted updating. Perhaps we should revisit that chapter at the end of the release cycle. DDL tests should be done in src/test/regress/sql/publication.sql rather than through TAP tests, to keep it simpler. I have added a few that I came up with (patch 0002). Note the FIXME marker that it does not recognize if the listed columns don't exist. I removed a now redundant test from the TAP test file. The other error condition test in the TAP test file ('publication relation test_part removed') I didn't understand: test_part was added with columns (a, b), so why would dropping column b remove the whole entry? Maybe I missed something, or this could be explained better. I was curious what happens when you have different publications with different column lists, so I wrote a test for that (patch 0003). It turns out it works, so there is nothing to do, but perhaps the test is useful to keep. The test file 021_column_filter.pl should be renamed to an unused number (would be 027 currently). Also, it contains references to "TRUNCATE", where it was presumably copied from. On the implementation side, I think the added catalog column pg_publication_rel.prattrs should be an int2 array, not a text array. That would also fix the above problem. If you have to look up the columns at DDL time, then you will notice when they don't exist. Finally, I suggest not naming this feature "column filter". I think this name arose because of the analogy with the "row filter" feature also being developed. But a filter is normally a dynamic data-driven action, which this is not. Golden Gate calls it in their documentation "Selecting Columns", or we could just call it "column list". --------------l5L0oS80CIgiENkK7lOqL2CH Content-Type: text/plain; charset=UTF-8; name="0001-Add-some-documentation.patch" Content-Disposition: attachment; filename="0001-Add-some-documentation.patch" Content-Transfer-Encoding: base64 RnJvbSBjYzkwODJmZTZmOThlNWQ5ZDk5MjM3Nzc2MWQwNmI4YWFkZjNiMjdmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogRnJpLCAxMCBEZWMgMjAyMSAxMzoxOTo1MiArMDEwMApTdWJqZWN0 OiBbUEFUQ0ggMS8zXSBBZGQgc29tZSBkb2N1bWVudGF0aW9uCgotLS0KIGRvYy9zcmMvc2dt bC9yZWYvYWx0ZXJfcHVibGljYXRpb24uc2dtbCAgfCAgNCArKystCiBkb2Mvc3JjL3NnbWwv cmVmL2NyZWF0ZV9wdWJsaWNhdGlvbi5zZ21sIHwgMTEgKysrKysrKysrKy0KIDIgZmlsZXMg Y2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9kb2Mvc3JjL3NnbWwvcmVmL2FsdGVyX3B1YmxpY2F0aW9uLnNnbWwgYi9kb2Mvc3JjL3Nn bWwvcmVmL2FsdGVyX3B1YmxpY2F0aW9uLnNnbWwKaW5kZXggYmI0ZWY1ZTVlMi4uYzg2MDU1 YjkzYyAxMDA2NDQKLS0tIGEvZG9jL3NyYy9zZ21sL3JlZi9hbHRlcl9wdWJsaWNhdGlvbi5z Z21sCisrKyBiL2RvYy9zcmMvc2dtbC9yZWYvYWx0ZXJfcHVibGljYXRpb24uc2dtbApAQCAt MzAsNyArMzAsNyBAQAogCiA8cGhyYXNlPndoZXJlIDxyZXBsYWNlYWJsZSBjbGFzcz0icGFy YW1ldGVyIj5wdWJsaWNhdGlvbl9vYmplY3Q8L3JlcGxhY2VhYmxlPiBpcyBvbmUgb2Y6PC9w aHJhc2U+CiAKLSAgICBUQUJMRSBbIE9OTFkgXSA8cmVwbGFjZWFibGUgY2xhc3M9InBhcmFt ZXRlciI+dGFibGVfbmFtZTwvcmVwbGFjZWFibGU+IFsgKiBdIFssIC4uLiBdCisgICAgVEFC TEUgWyBPTkxZIF0gPHJlcGxhY2VhYmxlIGNsYXNzPSJwYXJhbWV0ZXIiPnRhYmxlX25hbWU8 L3JlcGxhY2VhYmxlPiBbICogXSAgWyAoIDxyZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1ldGVy Ij5jb2x1bW5fbmFtZTwvcmVwbGFjZWFibGU+LCBbLCAuLi4gXSApIF0gWywgLi4uIF0KICAg ICBBTEwgVEFCTEVTIElOIFNDSEVNQSB7IDxyZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1ldGVy Ij5zY2hlbWFfbmFtZTwvcmVwbGFjZWFibGU+IHwgQ1VSUkVOVF9TQ0hFTUEgfSBbLCAuLi4g XQogPC9zeW5vcHNpcz4KICA8L3JlZnN5bm9wc2lzZGl2PgpAQCAtMTEwLDYgKzExMCw4IEBA IDx0aXRsZT5QYXJhbWV0ZXJzPC90aXRsZT4KICAgICAgIHNwZWNpZmllZCwgdGhlIHRhYmxl IGFuZCBhbGwgaXRzIGRlc2NlbmRhbnQgdGFibGVzIChpZiBhbnkpIGFyZQogICAgICAgYWZm ZWN0ZWQuICBPcHRpb25hbGx5LCA8bGl0ZXJhbD4qPC9saXRlcmFsPiBjYW4gYmUgc3BlY2lm aWVkIGFmdGVyIHRoZSB0YWJsZQogICAgICAgbmFtZSB0byBleHBsaWNpdGx5IGluZGljYXRl IHRoYXQgZGVzY2VuZGFudCB0YWJsZXMgYXJlIGluY2x1ZGVkLgorICAgICAgT3B0aW9uYWxs eSwgYSBjb2x1bW4gbGlzdCBjYW4gYmUgc3BlY2lmaWVkLiAgU2VlIDx4cmVmCisgICAgICBs aW5rZW5kPSJzcWwtY3JlYXRlcHVibGljYXRpb24iLz4gZm9yIGRldGFpbHMuCiAgICAgIDwv cGFyYT4KICAgICA8L2xpc3RpdGVtPgogICAgPC92YXJsaXN0ZW50cnk+CmRpZmYgLS1naXQg YS9kb2Mvc3JjL3NnbWwvcmVmL2NyZWF0ZV9wdWJsaWNhdGlvbi5zZ21sIGIvZG9jL3NyYy9z Z21sL3JlZi9jcmVhdGVfcHVibGljYXRpb24uc2dtbAppbmRleCBkODA1ZThlNzdhLi43M2Ey M2NiYjAyIDEwMDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwvcmVmL2NyZWF0ZV9wdWJsaWNhdGlv bi5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9yZWYvY3JlYXRlX3B1YmxpY2F0aW9uLnNnbWwK QEAgLTI4LDcgKzI4LDcgQEAKIAogPHBocmFzZT53aGVyZSA8cmVwbGFjZWFibGUgY2xhc3M9 InBhcmFtZXRlciI+cHVibGljYXRpb25fb2JqZWN0PC9yZXBsYWNlYWJsZT4gaXMgb25lIG9m OjwvcGhyYXNlPgogCi0gICAgVEFCTEUgWyBPTkxZIF0gPHJlcGxhY2VhYmxlIGNsYXNzPSJw YXJhbWV0ZXIiPnRhYmxlX25hbWU8L3JlcGxhY2VhYmxlPiBbICogXSBbLCAuLi4gXQorICAg IFRBQkxFIFsgT05MWSBdIDxyZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1ldGVyIj50YWJsZV9u YW1lPC9yZXBsYWNlYWJsZT4gWyAqIF0gWyAoIDxyZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1l dGVyIj5jb2x1bW5fbmFtZTwvcmVwbGFjZWFibGU+LCBbLCAuLi4gXSApIF0gWywgLi4uIF0K ICAgICBBTEwgVEFCTEVTIElOIFNDSEVNQSB7IDxyZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1l dGVyIj5zY2hlbWFfbmFtZTwvcmVwbGFjZWFibGU+IHwgQ1VSUkVOVF9TQ0hFTUEgfSBbLCAu Li4gXQogPC9zeW5vcHNpcz4KICA8L3JlZnN5bm9wc2lzZGl2PgpAQCAtNzgsNiArNzgsMTUg QEAgPHRpdGxlPlBhcmFtZXRlcnM8L3RpdGxlPgogICAgICAgcHVibGljYXRpb24sIHNvIHRo ZXkgYXJlIG5ldmVyIGV4cGxpY2l0bHkgYWRkZWQgdG8gdGhlIHB1YmxpY2F0aW9uLgogICAg ICA8L3BhcmE+CiAKKyAgICAgPHBhcmE+CisgICAgICBXaGVuIGEgY29sdW1uIGxpc3QgaXMg c3BlY2lmaWVkLCBvbmx5IHRoZSBsaXN0ZWQgY29sdW1ucyBhcmUgcmVwbGljYXRlZDsKKyAg ICAgIGFueSBvdGhlciBjb2x1bW5zIGFyZSBpZ25vcmVkIGZvciB0aGUgcHVycG9zZSBvZiBy ZXBsaWNhdGlvbiB0aHJvdWdoCisgICAgICB0aGlzIHB1YmxpY2F0aW9uLiAgSWYgbm8gY29s dW1uIGxpc3QgaXMgc3BlY2lmaWVkLCBhbGwgY29sdW1ucyBvZiB0aGUKKyAgICAgIHRhYmxl IGFyZSByZXBsaWNhdGVkIHRocm91Z2ggdGhpcyBwdWJsaWNhdGlvbiwgaW5jbHVkaW5nIGFu eSBjb2x1bW5zCisgICAgICBhZGRlZCBsYXRlci4gIElmIGEgY29sdW1uIGxpc3QgaXMgc3Bl Y2lmaWVkLCBpdCBtdXN0IGluY2x1ZGUgdGhlIHJlcGxpY2EKKyAgICAgIGlkZW50aXR5IGNv bHVtbnMuCisgICAgIDwvcGFyYT4KKwogICAgICA8cGFyYT4KICAgICAgIE9ubHkgcGVyc2lz dGVudCBiYXNlIHRhYmxlcyBhbmQgcGFydGl0aW9uZWQgdGFibGVzIGNhbiBiZSBwYXJ0IG9m IGEKICAgICAgIHB1YmxpY2F0aW9uLiAgVGVtcG9yYXJ5IHRhYmxlcywgdW5sb2dnZWQgdGFi bGVzLCBmb3JlaWduIHRhYmxlcywKLS0gCjIuMzQuMQoK --------------l5L0oS80CIgiENkK7lOqL2CH Content-Type: text/plain; charset=UTF-8; name="0002-Add-regression-tests.patch" Content-Disposition: attachment; filename="0002-Add-regression-tests.patch" Content-Transfer-Encoding: base64 RnJvbSBkYWRjNDFiMTM5YzM1MjgxMWY1OTU2ODkyYzAyMTM1OTA1MjYzMzQ3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogRnJpLCAxMCBEZWMgMjAyMSAxMzo0MDo1MCArMDEwMApTdWJqZWN0 OiBbUEFUQ0ggMi8zXSBBZGQgcmVncmVzc2lvbiB0ZXN0cwoKLS0tCiBzcmMvdGVzdC9yZWdy ZXNzL2V4cGVjdGVkL3B1YmxpY2F0aW9uLm91dCAgICB8IDE2ICsrKysrKysrKysrKysrKy0K IHNyYy90ZXN0L3JlZ3Jlc3Mvc3FsL3B1YmxpY2F0aW9uLnNxbCAgICAgICAgIHwgMTIgKysr KysrKysrKystCiBzcmMvdGVzdC9zdWJzY3JpcHRpb24vdC8wMjFfY29sdW1uX2ZpbHRlci5w bCB8ICA2ICstLS0tLQogMyBmaWxlcyBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCA3IGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvcHVi bGljYXRpb24ub3V0IGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9wdWJsaWNhdGlvbi5v dXQKaW5kZXggNWFjMmQ2NjZhMi4uYzYwMTdjMDUxNCAxMDA2NDQKLS0tIGEvc3JjL3Rlc3Qv cmVncmVzcy9leHBlY3RlZC9wdWJsaWNhdGlvbi5vdXQKKysrIGIvc3JjL3Rlc3QvcmVncmVz cy9leHBlY3RlZC9wdWJsaWNhdGlvbi5vdXQKQEAgLTE2NSw3ICsxNjUsMjEgQEAgUHVibGlj YXRpb25zOgogIHJlZ3Jlc3NfcHVibGljYXRpb25fdXNlciB8IHQgICAgICAgICAgfCB0ICAg ICAgIHwgdCAgICAgICB8IGYgICAgICAgfCBmICAgICAgICAgfCBmCiAoMSByb3cpCiAKLURS T1AgVEFCTEUgdGVzdHB1Yl90YmwyOworQ1JFQVRFIFRBQkxFIHRlc3RwdWJfdGJsNSAoYSBp bnQgUFJJTUFSWSBLRVksIGIgdGV4dCwgYyB0ZXh0KTsKK0FMVEVSIFBVQkxJQ0FUSU9OIHRl c3RwdWJfZm9ydGFibGUgQUREIFRBQkxFIHRlc3RwdWJfdGJsNSAoeCwgeSwgeik7ICAtLSBl cnJvcgorRVJST1I6ICBjYW5ub3QgYWRkIHJlbGF0aW9uICJ0ZXN0cHViX3RibDUiIHRvIHB1 YmxpY2F0aW9uCitERVRBSUw6ICBDb2x1bW4gZmlsdGVyIG11c3QgaW5jbHVkZSBSRVBMSUNB IElERU5USVRZIGNvbHVtbnMKK0FMVEVSIFBVQkxJQ0FUSU9OIHRlc3RwdWJfZm9ydGFibGUg QUREIFRBQkxFIHRlc3RwdWJfdGJsNSAoYSwgeCk7ICAtLSBlcnJvciBGSVhNRQorQUxURVIg UFVCTElDQVRJT04gdGVzdHB1Yl9mb3J0YWJsZSBBREQgVEFCTEUgdGVzdHB1Yl90Ymw1IChi LCBjKTsgIC0tIGVycm9yCitFUlJPUjogIHJlbGF0aW9uICJ0ZXN0cHViX3RibDUiIGlzIGFs cmVhZHkgbWVtYmVyIG9mIHB1YmxpY2F0aW9uICJ0ZXN0cHViX2ZvcnRhYmxlIgorQUxURVIg UFVCTElDQVRJT04gdGVzdHB1Yl9mb3J0YWJsZSBBREQgVEFCTEUgdGVzdHB1Yl90Ymw1IChh LCBjKTsgIC0tIG9rCitFUlJPUjogIHJlbGF0aW9uICJ0ZXN0cHViX3RibDUiIGlzIGFscmVh ZHkgbWVtYmVyIG9mIHB1YmxpY2F0aW9uICJ0ZXN0cHViX2ZvcnRhYmxlIgorQ1JFQVRFIFRB QkxFIHRlc3RwdWJfdGJsNiAoYSBpbnQsIGIgdGV4dCwgYyB0ZXh0KTsKK0FMVEVSIFRBQkxF IHRlc3RwdWJfdGJsNiBSRVBMSUNBIElERU5USVRZIEZVTEw7CitBTFRFUiBQVUJMSUNBVElP TiB0ZXN0cHViX2ZvcnRhYmxlIEFERCBUQUJMRSB0ZXN0cHViX3RibDYgKGEsIGIsIGMpOyAg LS0gZXJyb3IKK0VSUk9SOiAgY2Fubm90IGFkZCByZWxhdGlvbiAidGVzdHB1Yl90Ymw2IiB0 byBwdWJsaWNhdGlvbgorREVUQUlMOiAgQ2Fubm90IGhhdmUgY29sdW1uIGZpbHRlciB3aXRo IFJFUExJQ0EgSURFTlRJVFkgRlVMTAorRFJPUCBUQUJMRSB0ZXN0cHViX3RibDIsIHRlc3Rw dWJfdGJsNSwgdGVzdHB1Yl90Ymw2OwogRFJPUCBQVUJMSUNBVElPTiB0ZXN0cHViX2ZvcmFs bHRhYmxlcywgdGVzdHB1Yl9mb3J0YWJsZSwgdGVzdHB1Yl9mb3JzY2hlbWE7CiBDUkVBVEUg VEFCTEUgdGVzdHB1Yl90YmwzIChhIGludCk7CiBDUkVBVEUgVEFCTEUgdGVzdHB1Yl90Ymwz YSAoYiB0ZXh0KSBJTkhFUklUUyAodGVzdHB1Yl90YmwzKTsKZGlmZiAtLWdpdCBhL3NyYy90 ZXN0L3JlZ3Jlc3Mvc3FsL3B1YmxpY2F0aW9uLnNxbCBiL3NyYy90ZXN0L3JlZ3Jlc3Mvc3Fs L3B1YmxpY2F0aW9uLnNxbAppbmRleCA1NmRkMzU4NTU0Li5iMmZkNzkzYzYxIDEwMDY0NAot LS0gYS9zcmMvdGVzdC9yZWdyZXNzL3NxbC9wdWJsaWNhdGlvbi5zcWwKKysrIGIvc3JjL3Rl c3QvcmVncmVzcy9zcWwvcHVibGljYXRpb24uc3FsCkBAIC04OSw3ICs4OSwxNyBAQCBDUkVB VEUgUFVCTElDQVRJT04gdGVzdHB1Yl9mb3JfdGJsX3NjaGVtYSBGT1IgQUxMIFRBQkxFUyBJ TiBTQ0hFTUEgcHViX3Rlc3QsIFRBQgogXGQrIHRlc3RwdWJfdGJsMgogXGRScCsgdGVzdHB1 Yl9mb3JhbGx0YWJsZXMKIAotRFJPUCBUQUJMRSB0ZXN0cHViX3RibDI7CitDUkVBVEUgVEFC TEUgdGVzdHB1Yl90Ymw1IChhIGludCBQUklNQVJZIEtFWSwgYiB0ZXh0LCBjIHRleHQpOwor QUxURVIgUFVCTElDQVRJT04gdGVzdHB1Yl9mb3J0YWJsZSBBREQgVEFCTEUgdGVzdHB1Yl90 Ymw1ICh4LCB5LCB6KTsgIC0tIGVycm9yCitBTFRFUiBQVUJMSUNBVElPTiB0ZXN0cHViX2Zv cnRhYmxlIEFERCBUQUJMRSB0ZXN0cHViX3RibDUgKGEsIHgpOyAgLS0gZXJyb3IgRklYTUUK K0FMVEVSIFBVQkxJQ0FUSU9OIHRlc3RwdWJfZm9ydGFibGUgQUREIFRBQkxFIHRlc3RwdWJf dGJsNSAoYiwgYyk7ICAtLSBlcnJvcgorQUxURVIgUFVCTElDQVRJT04gdGVzdHB1Yl9mb3J0 YWJsZSBBREQgVEFCTEUgdGVzdHB1Yl90Ymw1IChhLCBjKTsgIC0tIG9rCisKK0NSRUFURSBU QUJMRSB0ZXN0cHViX3RibDYgKGEgaW50LCBiIHRleHQsIGMgdGV4dCk7CitBTFRFUiBUQUJM RSB0ZXN0cHViX3RibDYgUkVQTElDQSBJREVOVElUWSBGVUxMOworQUxURVIgUFVCTElDQVRJ T04gdGVzdHB1Yl9mb3J0YWJsZSBBREQgVEFCTEUgdGVzdHB1Yl90Ymw2IChhLCBiLCBjKTsg IC0tIGVycm9yCisKK0RST1AgVEFCTEUgdGVzdHB1Yl90YmwyLCB0ZXN0cHViX3RibDUsIHRl c3RwdWJfdGJsNjsKIERST1AgUFVCTElDQVRJT04gdGVzdHB1Yl9mb3JhbGx0YWJsZXMsIHRl c3RwdWJfZm9ydGFibGUsIHRlc3RwdWJfZm9yc2NoZW1hOwogCiBDUkVBVEUgVEFCTEUgdGVz dHB1Yl90YmwzIChhIGludCk7CmRpZmYgLS1naXQgYS9zcmMvdGVzdC9zdWJzY3JpcHRpb24v dC8wMjFfY29sdW1uX2ZpbHRlci5wbCBiL3NyYy90ZXN0L3N1YnNjcmlwdGlvbi90LzAyMV9j b2x1bW5fZmlsdGVyLnBsCmluZGV4IDdiNTJkNDU5M2QuLjAyZTA1NDIwZjEgMTAwNjQ0Ci0t LSBhL3NyYy90ZXN0L3N1YnNjcmlwdGlvbi90LzAyMV9jb2x1bW5fZmlsdGVyLnBsCisrKyBi L3NyYy90ZXN0L3N1YnNjcmlwdGlvbi90LzAyMV9jb2x1bW5fZmlsdGVyLnBsCkBAIC01LDcg KzUsNyBAQAogdXNlIHdhcm5pbmdzOwogdXNlIFBvc3RncmVTUUw6OlRlc3Q6OkNsdXN0ZXI7 CiB1c2UgUG9zdGdyZVNRTDo6VGVzdDo6VXRpbHM7Ci11c2UgVGVzdDo6TW9yZSB0ZXN0cyA9 PiA5OwordXNlIFRlc3Q6Ok1vcmUgdGVzdHMgPT4gODsKIAogIyBzZXR1cAogCkBAIC0xMzAs MTAgKzEzMCw2IEBACiBpcygkcmVzdWx0LCBxcSgxfGFiYyksICd1cGRhdGUgb24gY29sdW1u IGMgaXMgbm90IHJlcGxpY2F0ZWQnKTsKIAogI1Rlc3QgZXJyb3IgY29uZGl0aW9ucwotbXkg KCRwc3FsX3JjLCAkcHNxbF9vdXQsICRwc3FsX2VycikgPSAkbm9kZV9wdWJsaXNoZXItPnBz cWwoJ3Bvc3RncmVzJywKLQkiQ1JFQVRFIFBVQkxJQ0FUSU9OIHB1YjIgRk9SIFRBQkxFIHRl c3RfcGFydChiKSIpOwotbGlrZSgkcHNxbF9lcnIsIHFyL0NvbHVtbiBmaWx0ZXIgbXVzdCBp bmNsdWRlIFJFUExJQ0EgSURFTlRJVFkgY29sdW1ucy8sICdFcnJvciB3aGVuIGNvbHVtbiBm aWx0ZXIgZG9lcyBub3QgY29udGFpbiBSRVBMSUNBIElERU5USVRZJyk7Ci0KICRub2RlX3B1 Ymxpc2hlci0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsCiAJIkFMVEVSIFRBQkxFIHRlc3RfcGFy dCBEUk9QIENPTFVNTiBiIik7CiAkcmVzdWx0ID0gJG5vZGVfcHVibGlzaGVyLT5zYWZlX3Bz cWwoJ3Bvc3RncmVzJywKLS0gCjIuMzQuMQoK --------------l5L0oS80CIgiENkK7lOqL2CH Content-Type: text/plain; charset=UTF-8; name="0003-Test-case-for-overlapping-column-lists.patch" Content-Disposition: attachment; filename="0003-Test-case-for-overlapping-column-lists.patch" Content-Transfer-Encoding: base64 RnJvbSA4ZjgzMDcwMDBmY2QwNDdmM2ExMWRkYzQzNjZlNmZkMzg2OTA4Mjk2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogRnJpLCAxMCBEZWMgMjAyMSAxMzo1MTozOCArMDEwMApTdWJqZWN0 OiBbUEFUQ0ggMy8zXSBUZXN0IGNhc2UgZm9yIG92ZXJsYXBwaW5nIGNvbHVtbiBsaXN0cwoK LS0tCiBzcmMvdGVzdC9zdWJzY3JpcHRpb24vdC8wMjFfY29sdW1uX2ZpbHRlci5wbCB8IDE3 ICsrKysrKysrKysrKysrKystCiAxIGZpbGUgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwg MSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3N1YnNjcmlwdGlvbi90LzAy MV9jb2x1bW5fZmlsdGVyLnBsIGIvc3JjL3Rlc3Qvc3Vic2NyaXB0aW9uL3QvMDIxX2NvbHVt bl9maWx0ZXIucGwKaW5kZXggMDJlMDU0MjBmMS4uMzgxNGFkMjM2NyAxMDA2NDQKLS0tIGEv c3JjL3Rlc3Qvc3Vic2NyaXB0aW9uL3QvMDIxX2NvbHVtbl9maWx0ZXIucGwKKysrIGIvc3Jj L3Rlc3Qvc3Vic2NyaXB0aW9uL3QvMDIxX2NvbHVtbl9maWx0ZXIucGwKQEAgLTUsNyArNSw3 IEBACiB1c2Ugd2FybmluZ3M7CiB1c2UgUG9zdGdyZVNRTDo6VGVzdDo6Q2x1c3RlcjsKIHVz ZSBQb3N0Z3JlU1FMOjpUZXN0OjpVdGlsczsKLXVzZSBUZXN0OjpNb3JlIHRlc3RzID0+IDg7 Cit1c2UgVGVzdDo6TW9yZSB0ZXN0cyA9PiA5OwogCiAjIHNldHVwCiAKQEAgLTEzNywzICsx MzcsMTggQEAKIGlzKCRyZXN1bHQsIHFxKHRhYjF8e2EsQn0KIHRhYjJ8e2EsYn0KIHRhYjN8 e2EnLGMnfSksICdwdWJsaWNhdGlvbiByZWxhdGlvbiB0ZXN0X3BhcnQgcmVtb3ZlZCcpOwor CisKKyRub2RlX3B1Ymxpc2hlci0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsICJDUkVBVEUgVEFC TEUgdGFiNCAoYSBpbnQgUFJJTUFSWSBLRVksIGIgaW50LCBjIGludCwgZCBpbnQpIik7Cisk bm9kZV9zdWJzY3JpYmVyLT5zYWZlX3BzcWwoJ3Bvc3RncmVzJywgIkNSRUFURSBUQUJMRSB0 YWI0IChhIGludCBQUklNQVJZIEtFWSwgYiBpbnQsIGQgaW50KSIpOworJG5vZGVfcHVibGlz aGVyLT5zYWZlX3BzcWwoJ3Bvc3RncmVzJywgIkNSRUFURSBQVUJMSUNBVElPTiBwdWIyIEZP UiBUQUJMRSB0YWI0IChhLCBiKSIpOworJG5vZGVfcHVibGlzaGVyLT5zYWZlX3BzcWwoJ3Bv c3RncmVzJywgIkNSRUFURSBQVUJMSUNBVElPTiBwdWIzIEZPUiBUQUJMRSB0YWI0IChhLCBk KSIpOworJG5vZGVfc3Vic2NyaWJlci0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsCSJDUkVBVEUg U1VCU0NSSVBUSU9OIHN1YjIgQ09OTkVDVElPTiAnJHB1Ymxpc2hlcl9jb25uc3RyJyBQVUJM SUNBVElPTiBwdWIyLCBwdWIzIik7Ciskbm9kZV9wdWJsaXNoZXItPndhaXRfZm9yX2NhdGNo dXAoJ3N1YjInKTsKKyRub2RlX3B1Ymxpc2hlci0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsICJJ TlNFUlQgSU5UTyB0YWI0IFZBTFVFUyAoMSwgMTEsIDExMSwgMTExMSkiKTsKKyRub2RlX3B1 Ymxpc2hlci0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsICJJTlNFUlQgSU5UTyB0YWI0IFZBTFVF UyAoMiwgMjIsIDIyMiwgMjIyMikiKTsKKyRub2RlX3B1Ymxpc2hlci0+d2FpdF9mb3JfY2F0 Y2h1cCgnc3ViMicpOworaXMoJG5vZGVfc3Vic2NyaWJlci0+c2FmZV9wc3FsKCdwb3N0Z3Jl cycsIlNFTEVDVCAqIEZST00gdGFiNDsiKSwKKwlxcSgxfDExfDExMTEKKzJ8MjJ8MjIyMiks CisJJ292ZXJsYXBwaW5nIHB1YmxpY2F0aW9ucyB3aXRoIG92ZXJsYXBwaW5nIGNvbHVtbiBs aXN0cycpOwotLSAKMi4zNC4xCgo= --------------l5L0oS80CIgiENkK7lOqL2CH--