Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tvfSE-006uwE-Mr for pgsql-hackers@arkaria.postgresql.org; Fri, 21 Mar 2025 16:42:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tvfSD-00BVN0-DP for pgsql-hackers@arkaria.postgresql.org; Fri, 21 Mar 2025 16:42:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tvfSD-00BVMs-3M for pgsql-hackers@lists.postgresql.org; Fri, 21 Mar 2025 16:42:41 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tvfSA-000LyL-0g for pgsql-hackers@postgresql.org; Fri, 21 Mar 2025 16:42:40 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 52LGgSxS1571162; Fri, 21 Mar 2025 12:42:28 -0400 From: Tom Lane To: Matheus Alcantara cc: Andrew Dunstan , Peter Eisentraut , Gabriele Bartolini , Craig Ringer , "David E. Wheeler" , Robert Haas , Alvaro Herrera , PostgreSQL-development Subject: Re: RFC: Additional Directory for Extensions In-reply-to: References: <0d384836-7e6e-4932-af3b-8dad1f6fee43@eisentraut.org> <4f7209ba-1ca2-475e-9a70-0f3fe0be6378@eisentraut.org> <12312928-5516-49b8-81c1-a7b56fd01bc8@dunslane.net> <38c53446-6b65-4222-b76b-351e56f4841c@eisentraut.org> <7c178ff3-20a5-493e-a704-e6b3263e782f@eisentraut.org> <784527.1742410558@sss.pgh.pa.us> Comments: In-reply-to Matheus Alcantara message dated "Fri, 21 Mar 2025 12:52:55 -0300" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <1571160.1742575348.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 21 Mar 2025 12:42:28 -0400 Message-ID: <1571161.1742575348@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Matheus Alcantara writes: > On Thu, Mar 20, 2025 at 7:38=E2=80=AFPM Andrew Dunstan wrote: >>> (wondering if this another of these cases where the "path includes pos= tgres" thing bites us, and we're looking in the wrong place) >> Nope, testing shows it's not that, so I am rather confused about what w= as going on. > I'm not sure if I'm checking on the right place [1] but it seems that th= e > Contrib and ContribInstall is executed after Check step which causes thi= s test > failure? No, this is not failing in Check. I did just notice a clue though: on snakefly, the failing step's log [1] includes make[1]: Leaving directory `/opt/postgres/build-farm-18/HEAD/pgsql.build/s= rc/backend' rm -rf '/opt/postgres/build-farm-18/HEAD/pgsql.build'/tmp_install /usr/bin/mkdir -p '/opt/postgres/build-farm-18/HEAD/pgsql.build'/tmp_insta= ll/log make -C '../../../..' DESTDIR=3D'/opt/postgres/build-farm-18/HEAD/pgsql.bu= ild'/tmp_install install >'/opt/postgres/build-farm-18/HEAD/pgsql.build'/t= mp_install/log/install.log 2>&1 make -j1 checkprep >>'/opt/postgres/build-farm-18/HEAD/pgsql.build'/tmp_i= nstall/log/install.log 2>&1 PATH=3D"/opt/postgres/build-farm-18/HEAD/pgsql.build/tmp_install/opt/postg= res/build-farm-18/HEAD/inst/bin:/opt/postgres/build-farm-18/HEAD/pgsql.bui= ld/src/test/modules/test_extensions:$PATH" LD_LIBRARY_PATH=3D"/opt/postgre= s/build-farm-18/HEAD/pgsql.build/tmp_install/opt/postgres/build-farm-18/HE= AD/inst/lib:$LD_LIBRARY_PATH" INITDB_TEMPLATE=3D'/opt/postgres/build-farm-= 18/HEAD/pgsql.build'/tmp_install/initdb-template initdb --auth trust --no= -sync --no-instructions --lc-messages=3DC --no-clean '/opt/postgres/build-= farm-18/HEAD/pgsql.build'/tmp_install/initdb-template >>'/opt/postgres/bui= ld-farm-18/HEAD/pgsql.build'/tmp_install/log/initdb-template.log 2>&1 echo "# +++ regress check in src/test/modules/test_extensions +++" && PATH= =3D"/opt/postgres/build-farm-18/HEAD/pgsql.build/tmp_install/opt/postgres/= build-farm-18/HEAD/inst/bin:/opt/postgres/build-farm-18/HEAD/pgsql.build/s= rc/test/modules/test_extensions:$PATH" LD_LIBRARY_PATH=3D"/opt/postgres/bu= ild-farm-18/HEAD/pgsql.build/tmp_install/opt/postgres/build-farm-18/HEAD/i= nst/lib:$LD_LIBRARY_PATH" INITDB_TEMPLATE=3D'/opt/postgres/build-farm-18/H= EAD/pgsql.build'/tmp_install/initdb-template ../../../../src/test/regress= /pg_regress --temp-instance=3D./tmp_check --inputdir=3D. --bindir=3D --te= mp-config=3D/opt/postgres/build-farm-18/tmp/buildfarm-C9Iy3s/bfextra.conf = --no-locale --port=3D5678 --dbname=3Dcontrib_regression test_extensions t= est_extdepend # +++ regress check in src/test/modules/test_extensions +++ # initializing database system by running initdb showing that the step made its own tmp_install, and that only the core "install" process was executed, so the lack of amcheck in that install tree is not surprising. But concurrent runs on other animals, eg [2], don't show a tmp_install rebuild happening. So those are using an installation tree that *does* include contrib modules. So what this comes down to is "why is snakefly doing a fresh install here?". I don't know the buildfarm client well enough to identify probable causes. I do note that Makefile.global.in conditionalizes tmp_install rebuild on several variables: temp-install: | submake-generated-headers ifndef NO_TEMP_INSTALL ifneq ($(abs_top_builddir),) ifeq ($(MAKELEVEL),0) rm -rf '$(abs_top_builddir)'/tmp_install $(MKDIR_P) '$(abs_top_builddir)'/tmp_install/log $(MAKE) -C '$(top_builddir)' DESTDIR=3D'$(abs_top_builddir)'/tmp_install = install >'$(abs_top_builddir)'/tmp_install/log/install.log 2>&1 $(MAKE) -j1 $(if $(CHECKPREP_TOP),-C $(CHECKPREP_TOP),) checkprep >>'$(ab= s_top_builddir)'/tmp_install/log/install.log 2>&1 I think we've had trouble before with that MAKELEVEL test... regards, tom lane [1] https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=3Dsnakef= ly&dt=3D2025-03-20%2009%3A46%3A05&stg=3Dmodule-test_extensions-check [2] https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=3Dalliga= tor&dt=3D2025-03-19%2006%3A10%3A38&stg=3Dmodule-test_extensions-check