Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goEbF-0000Ol-HG for pgsql-hackers@arkaria.postgresql.org; Mon, 28 Jan 2019 21:37:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1goEbE-00058P-8C for pgsql-hackers@arkaria.postgresql.org; Mon, 28 Jan 2019 21:37:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goEbD-00055E-T1 for pgsql-hackers@lists.postgresql.org; Mon, 28 Jan 2019 21:37:48 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goEbB-0006sq-G1 for pgsql-hackers@lists.postgresql.org; Mon, 28 Jan 2019 21:37:46 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x0SLbgwo015777; Mon, 28 Jan 2019 16:37:42 -0500 From: Tom Lane To: Andres Freund cc: pgsql-hackers@lists.postgresql.org Subject: Re: Proposed refactoring of planner header files In-reply-to: <20190128211231.7xtkq4lzlt44mmr2@alap3.anarazel.de> References: <11460.1548706639@sss.pgh.pa.us> <20190128203229.yreabsq6kinxdnh5@alap3.anarazel.de> <13179.1548708622@sss.pgh.pa.us> <20190128210211.4is52ckj2voz2bdl@alap3.anarazel.de> <20190128211231.7xtkq4lzlt44mmr2@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Mon, 28 Jan 2019 13:12:31 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <15775.1548711462.1@sss.pgh.pa.us> Date: Mon, 28 Jan 2019 16:37:42 -0500 Message-ID: <15776.1548711462@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Andres Freund writes: > On 2019-01-28 13:02:11 -0800, Andres Freund wrote: >> It's not required by C99, it however is required by C11. But a lot of >> compilers have allowed it as an extension for a long time (like before >> C99), unless suppressed by some option. > Hm, it's only in gcc 4.6, so that's probably too recent. Yeah, I tried it with RHEL6's gcc 4.4.7, and it doesn't work (and AFAICS there is no option that would make it work). A lot of the buildfarm is running compilers older than that. I fear we're still 10 years away from being able to demand C11 support ... regards, tom lane