Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8ucK-0007Fq-HR for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Mar 2019 22:32:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h8ucJ-0000RD-4H for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Mar 2019 22:32:23 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8ucI-0000R6-OD for pgsql-hackers@lists.postgresql.org; Tue, 26 Mar 2019 22:32:22 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8ucG-0005VU-7u for pgsql-hackers@lists.postgresql.org; Tue, 26 Mar 2019 22:32:21 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x2QMVao5015787; Tue, 26 Mar 2019 18:31:36 -0400 From: Tom Lane To: Ryan Lambert cc: Chapman Flack , pgsql-hackers@lists.postgresql.org, Pavel Stehule Subject: Re: Fix XML handling with DOCTYPE In-reply-to: References: <155355138978.16482.2985962575775445194.pgcf@coridan.postgresql.org> <5C995B96.6050204@anastigmatix.net> Comments: In-reply-to Ryan Lambert message dated "Tue, 26 Mar 2019 16:17:49 -0600" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <15785.1553639496.1@sss.pgh.pa.us> Date: Tue, 26 Mar 2019 18:31:36 -0400 Message-ID: <15786.1553639496@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Ryan Lambert writes: > Is the xml-functions-type-docfix-4.patch [1] the one needing review? I'll > test applying it and review the changes in better detail. Is there a > section in the docs that shows how to verify if the updated pages render > properly? I would assume the pages are build when installing from source. Plain old "make all" doesn't build the docs. See https://www.postgresql.org/docs/devel/docguide.html for tooling prerequisites and build instructions. (Usually people just build the HTML docs and look at them with a browser; the other doc formats are less interesting.) regards, tom lane