pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedpg13 PGDLLIMPORT list
10+ messages / 5 participants
[nested] [flat]
Commits from this thread:
2020-01-21 62c9b52231 ef8e6b2c2b 7c7026bb7a 1ef7332b78 9740cdbe5e 4a49149b9d dbe405b785 Add GUC variables for stat tracking and timeout as PGDLLIMPORT
* pg13 PGDLLIMPORT list
@ 2020-01-17 22:07 legrand legrand <legrand_legrand@hotmail.com>
0 siblings, 1 reply; 10+ messages in thread
From: legrand legrand @ 2020-01-17 22:07 UTC (permalink / raw)
To: pgsql-hackers
Hello,
would it be possible to add PGDLLIMPORT to permit to build following
extensions on windows
pg_stat_sql_plans:
src/include/pgstat.h
extern PGDLLIMPORT bool pgstat_track_activities;
pg_background:
src/include/storage/proc.h
extern PGDLLIMPORT int StatementTimeout;
Thanks in advance
Regards
PAscal
--
Sent from: https://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pg13 PGDLLIMPORT list
@ 2020-01-18 02:26 Michael Paquier <michael@paquier.xyz>
parent: legrand legrand <legrand_legrand@hotmail.com>
0 siblings, 2 replies; 10+ messages in thread
From: Michael Paquier @ 2020-01-18 02:26 UTC (permalink / raw)
To: legrand legrand <legrand_legrand@hotmail.com>; +Cc: pgsql-hackers
On Fri, Jan 17, 2020 at 03:07:48PM -0700, legrand legrand wrote:
> Would it be possible to add PGDLLIMPORT to permit to build following
> extensions on windows
>
> pg_stat_sql_plans:
> src/include/pgstat.h
> extern PGDLLIMPORT bool pgstat_track_activities;
>
> pg_background:
> src/include/storage/proc.h
> extern PGDLLIMPORT int StatementTimeout;
No objections from me to add both to what's imported. Do you have a
specific use-case in mind for an extension on Windows? Just
wondering..
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pg13 PGDLLIMPORT list
@ 2020-01-18 07:04 Amit Kapila <amit.kapila16@gmail.com>
parent: Michael Paquier <michael@paquier.xyz>
1 sibling, 1 reply; 10+ messages in thread
From: Amit Kapila @ 2020-01-18 07:04 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: legrand legrand <legrand_legrand@hotmail.com>; pgsql-hackers
On Sat, Jan 18, 2020 at 7:56 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Fri, Jan 17, 2020 at 03:07:48PM -0700, legrand legrand wrote:
> > Would it be possible to add PGDLLIMPORT to permit to build following
> > extensions on windows
> >
> > pg_stat_sql_plans:
> > src/include/pgstat.h
> > extern PGDLLIMPORT bool pgstat_track_activities;
> >
> > pg_background:
> > src/include/storage/proc.h
> > extern PGDLLIMPORT int StatementTimeout;
>
> No objections from me to add both to what's imported.
>
+1 for adding PGDLLIMPORT to these variables. In the past, we have
added it on the request of some extension authors, so I don't see any
problem doing this time as well.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pg13 PGDLLIMPORT list
@ 2020-01-18 07:19 Julien Rouhaud <rjuju123@gmail.com>
parent: Amit Kapila <amit.kapila16@gmail.com>
0 siblings, 1 reply; 10+ messages in thread
From: Julien Rouhaud @ 2020-01-18 07:19 UTC (permalink / raw)
To: Amit Kapila <amit.kapila16@gmail.com>; +Cc: Michael Paquier <michael@paquier.xyz>; legrand legrand <legrand_legrand@hotmail.com>; pgsql-hackers
On Sat, 18 Jan 2020, 09:04 Amit Kapila <amit.kapila16@gmail.com wrote:
> On Sat, Jan 18, 2020 at 7:56 AM Michael Paquier <michael@paquier.xyz>
> wrote:
> >
> > On Fri, Jan 17, 2020 at 03:07:48PM -0700, legrand legrand wrote:
> > > Would it be possible to add PGDLLIMPORT to permit to build following
> > > extensions on windows
> > >
> > > pg_stat_sql_plans:
> > > src/include/pgstat.h
> > > extern PGDLLIMPORT bool pgstat_track_activities;
> > >
> > > pg_background:
> > > src/include/storage/proc.h
> > > extern PGDLLIMPORT int StatementTimeout;
> >
> > No objections from me to add both to what's imported.
> >
>
> +1 for adding PGDLLIMPORT to these variables. In the past, we have
> added it on the request of some extension authors, so I don't see any
> problem doing this time as well.
>
+1 too
>
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pg13 PGDLLIMPORT list
@ 2020-01-18 09:32 legrand legrand <legrand_legrand@hotmail.com>
parent: Michael Paquier <michael@paquier.xyz>
1 sibling, 1 reply; 10+ messages in thread
From: legrand legrand @ 2020-01-18 09:32 UTC (permalink / raw)
To: pgsql-hackers
Michael Paquier-2 wrote
> On Fri, Jan 17, 2020 at 03:07:48PM -0700, legrand legrand wrote:
> [...]
>
> No objections from me to add both to what's imported. Do you have a
> specific use-case in mind for an extension on Windows? Just
> wondering..
> --
> Michael
>
> signature.asc (849 bytes)
> <https://www.postgresql-archive.org/attachment/6119761/0/signature.asc>
No specific use-case, just the need to test features (IVM, push agg to base
relations and joins, ...)
on a professional laptop in windows 10 for a nomad app that collects
performance metrics on Oracle
databases.
Regards
PAscal
--
Sent from: https://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pg13 PGDLLIMPORT list
@ 2020-01-18 09:48 Michael Paquier <michael@paquier.xyz>
parent: legrand legrand <legrand_legrand@hotmail.com>
0 siblings, 0 replies; 10+ messages in thread
From: Michael Paquier @ 2020-01-18 09:48 UTC (permalink / raw)
To: legrand legrand <legrand_legrand@hotmail.com>; +Cc: pgsql-hackers
On Sat, Jan 18, 2020 at 02:32:49AM -0700, legrand legrand wrote:
> No specific use-case, just the need to test features (IVM, push agg to base
> relations and joins, ...)
> on a professional laptop in windows 10 for a nomad app that collects
> performance metrics on Oracle
> databases.
That pretty much is a use-case, at least to me :)
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pg13 PGDLLIMPORT list
@ 2020-01-18 09:49 Michael Paquier <michael@paquier.xyz>
parent: Julien Rouhaud <rjuju123@gmail.com>
0 siblings, 1 reply; 10+ messages in thread
From: Michael Paquier @ 2020-01-18 09:49 UTC (permalink / raw)
To: Julien Rouhaud <rjuju123@gmail.com>; +Cc: Amit Kapila <amit.kapila16@gmail.com>; legrand legrand <legrand_legrand@hotmail.com>; pgsql-hackers
On Sat, Jan 18, 2020 at 09:19:19AM +0200, Julien Rouhaud wrote:
> On Sat, 18 Jan 2020, 09:04 Amit Kapila <amit.kapila16@gmail.com wrote:
>> +1 for adding PGDLLIMPORT to these variables. In the past, we have
>> added it on the request of some extension authors, so I don't see any
>> problem doing this time as well.
>>
>
> +1 too
Thanks. If there are no objections, I would like to actually
back-patch that.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pg13 PGDLLIMPORT list
@ 2020-01-21 03:04 Amit Kapila <amit.kapila16@gmail.com>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 10+ messages in thread
From: Amit Kapila @ 2020-01-21 03:04 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: Julien Rouhaud <rjuju123@gmail.com>; legrand legrand <legrand_legrand@hotmail.com>; pgsql-hackers
On Sat, Jan 18, 2020 at 3:19 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Sat, Jan 18, 2020 at 09:19:19AM +0200, Julien Rouhaud wrote:
> > On Sat, 18 Jan 2020, 09:04 Amit Kapila <amit.kapila16@gmail.com wrote:
> >> +1 for adding PGDLLIMPORT to these variables. In the past, we have
> >> added it on the request of some extension authors, so I don't see any
> >> problem doing this time as well.
> >>
> >
> > +1 too
>
> Thanks. If there are no objections, I would like to actually
> back-patch that.
>
As such no objection, but I am not sure if the other person need it on
back branches as well. Are you planning to commit this, or if you
want I can take care of it?
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pg13 PGDLLIMPORT list
@ 2020-01-21 04:49 Michael Paquier <michael@paquier.xyz>
parent: Amit Kapila <amit.kapila16@gmail.com>
0 siblings, 1 reply; 10+ messages in thread
From: Michael Paquier @ 2020-01-21 04:49 UTC (permalink / raw)
To: Amit Kapila <amit.kapila16@gmail.com>; +Cc: Julien Rouhaud <rjuju123@gmail.com>; legrand legrand <legrand_legrand@hotmail.com>; pgsql-hackers
On Tue, Jan 21, 2020 at 08:34:05AM +0530, Amit Kapila wrote:
> As such no objection, but I am not sure if the other person need it on
> back branches as well. Are you planning to commit this, or if you
> want I can take care of it?
Thanks for the reminder. Done now. I have also switched the
surrounding parameters while on it to not be inconsistent.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pg13 PGDLLIMPORT list
@ 2020-01-21 07:07 Craig Ringer <craig@2ndquadrant.com>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 10+ messages in thread
From: Craig Ringer @ 2020-01-21 07:07 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: Amit Kapila <amit.kapila16@gmail.com>; Julien Rouhaud <rjuju123@gmail.com>; legrand legrand <legrand_legrand@hotmail.com>; pgsql-hackers
On Tue, 21 Jan 2020 at 12:49, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Jan 21, 2020 at 08:34:05AM +0530, Amit Kapila wrote:
> > As such no objection, but I am not sure if the other person need it on
> > back branches as well. Are you planning to commit this, or if you
> > want I can take care of it?
>
> Thanks for the reminder. Done now. I have also switched the
> surrounding parameters while on it to not be inconsistent.
While speaking of PGDLLIMPORT, I wrote a quick check target in the
makefiles for some extensions I work on. It identified the following
symbols as used by the extensions but not exported:
XactLastRecEnd (xlog.h)
criticalSharedRelcachesBuilt (relcache.h)
hot_standby_feedback (walreceiver.h)
pgstat_track_activities (pgstat.h)
WalRcv (walreceiver.h)
wal_receiver_status_interval (walreceiver.h)
wal_retrieve_retry_interval (walreceiver.h)
Of those, XactLastRecEnd is by far the most important.
Failure to export pgstat_track_activities is a bug IMO, since it's
exported by inline functions pgstat_report_wait_start() and
pgstat_report_wait_end() in pgstat.h
criticalSharedRelcachesBuilt is useful in extensions that may do genam
systable_beginscan() etc in functions called both early in startup and
later on.
hot_standby_feedback can be worked around by reading the GUC via the
config options interface. But IMO all GUC symbols should be
PGDLLEXPORTed, especially since we lack an interface for extensions to
read arbitrary GUC values w/o formatting to string then parsing the
string.
wal_receiver_status_interval and wal_retrieve_retry_interval are not
that important, but again they're GUCs.
Being able to see WalRcv is very useful when running extension code on
a streaming physical replica, where you want to make decisions based
on what's actually replicated.
Anyone object to exporting these?
--
Craig Ringer http://www.2ndQuadrant.com/
2ndQuadrant - PostgreSQL Solutions for the Enterprise
^ permalink raw reply [nested|flat] 10+ messages in thread
end of thread, other threads:[~2020-01-21 07:07 UTC | newest]
Thread overview: 10+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-01-17 22:07 pg13 PGDLLIMPORT list legrand legrand <legrand_legrand@hotmail.com>
2020-01-18 02:26 ` Michael Paquier <michael@paquier.xyz>
2020-01-18 07:04 ` Amit Kapila <amit.kapila16@gmail.com>
2020-01-18 07:19 ` Julien Rouhaud <rjuju123@gmail.com>
2020-01-18 09:49 ` Michael Paquier <michael@paquier.xyz>
2020-01-21 03:04 ` Amit Kapila <amit.kapila16@gmail.com>
2020-01-21 04:49 ` Michael Paquier <michael@paquier.xyz>
2020-01-21 07:07 ` Craig Ringer <craig@2ndquadrant.com>
2020-01-18 09:32 ` legrand legrand <legrand_legrand@hotmail.com>
2020-01-18 09:48 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox