Message-ID: <157f5f76-8337-dc29-8e3c-ea59fb56b823@oss.nttdata.com>
Date: Thu, 7 Jul 2022 22:45:39 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: Add checkpoint and redo LSN to LogCheckpointEnd log message
Content-Language: en-US
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: michael@paquier.xyz, bharath.rupireddyforpostgres@gmail.com,
 nathandbossart@gmail.com, sfrost@snowman.net, bossartn@amazon.com,
 rjuju123@gmail.com, pgsql-hackers@lists.postgresql.org
References: <20220316.091913.806120467943749797.horikyota.ntt@gmail.com>
 <20220316.102947.378283819592596734.horikyota.ntt@gmail.com>
 <9a762503-79c9-e7aa-191a-9bfa0d77cc38@oss.nttdata.com>
 <20220707.162659.422073547959031915.horikyota.ntt@gmail.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <20220707.162659.422073547959031915.horikyota.ntt@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/157f5f76-8337-dc29-8e3c-ea59fb56b823%40oss.nttdata.com>
Precedence: bulk


On 2022/07/07 16:26, Kyotaro Horiguchi wrote:
>> + * ControlFileLock is not required as we are the only
>> +						 * updator of these variables.
>>
>> Isn't it better to add "at this time" or something at the end of the
>> comment because only we're not always updator of them? No?
> 
> Excluding initialization, (I believe) checkpointer is really the only
> updator of the variables/members.  But I'm fine with the addition.

Ok, so I modified the patch slightly and pushed it. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION